From 38dee63ee1bf2b4e90dfc285ade432b3c872e189 Mon Sep 17 00:00:00 2001 From: Aaditya Panikath Date: Tue, 15 Oct 2019 11:46:51 +0530 Subject: [PATCH 1/3] CLN: Fix mypy errors in pandas/tests/extension/json/array.py Enabled mypy test --- setup.cfg | 3 --- 1 file changed, 3 deletions(-) diff --git a/setup.cfg b/setup.cfg index 64494bf84363e..e3add80d5dcdf 100644 --- a/setup.cfg +++ b/setup.cfg @@ -157,9 +157,6 @@ ignore_errors=True [mypy-pandas.tests.extension.decimal.test_decimal] ignore_errors=True -[mypy-pandas.tests.extension.json.array] -ignore_errors=True - [mypy-pandas.tests.extension.json.test_json] ignore_errors=True From 974f0ee741d797e5b06030cee4846bd26f946053 Mon Sep 17 00:00:00 2001 From: Aaditya Panikath Date: Tue, 15 Oct 2019 11:48:03 +0530 Subject: [PATCH 2/3] CLN: Fix mypy errors in pandas/tests/extension/json/array.py Added type --- pandas/tests/extension/json/array.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/extension/json/array.py b/pandas/tests/extension/json/array.py index b64ddbd6ac84d..e51aea05e734f 100644 --- a/pandas/tests/extension/json/array.py +++ b/pandas/tests/extension/json/array.py @@ -27,7 +27,7 @@ class JSONDtype(ExtensionDtype): type = abc.Mapping name = "json" - na_value = UserDict() + na_value = UserDict() # type: UserDict @classmethod def construct_array_type(cls): From 5c87147acdfab9b4209b982d641b66b4ce4d8aa5 Mon Sep 17 00:00:00 2001 From: Aaditya Panikath Date: Thu, 17 Oct 2019 11:14:09 +0530 Subject: [PATCH 3/3] CLN: Fix mypy errors in pandas/tests/extension/json/array.py changed type --- pandas/tests/extension/json/array.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pandas/tests/extension/json/array.py b/pandas/tests/extension/json/array.py index e51aea05e734f..94bef0617df3c 100644 --- a/pandas/tests/extension/json/array.py +++ b/pandas/tests/extension/json/array.py @@ -16,6 +16,7 @@ import random import string import sys +from typing import Mapping import numpy as np @@ -27,7 +28,7 @@ class JSONDtype(ExtensionDtype): type = abc.Mapping name = "json" - na_value = UserDict() # type: UserDict + na_value = UserDict() # type: Mapping[type, type] @classmethod def construct_array_type(cls):