Skip to content

Bad syntax highlighting for comments inside arrow function #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rpereira opened this issue Apr 10, 2016 · 4 comments
Closed

Bad syntax highlighting for comments inside arrow function #368

rpereira opened this issue Apr 10, 2016 · 4 comments

Comments

@rpereira
Copy link

After the last update, the comments inside arrow functions are not highlighted correctly. Consider the following screenshot as an example.

screen shot 2016-04-10 at 16 33 14
@amadeus
Copy link
Collaborator

amadeus commented Apr 11, 2016

Is this an arrow function declaration within a class definition? If so, then it's a duplicate of #365 and I have a PR ready at #366

@amadeus
Copy link
Collaborator

amadeus commented Apr 11, 2016

Bump: Ya'll maintainers cool if I go ahead and merge this in? It's a pretty quick and simple fix.

@rpereira
Copy link
Author

@amadeus, yes, it is within a class definition. Before opening I took a look at that issue and I didn't see the comments in your example. My bad. Sorry for the duplication.

This issue will be automatically closed as soon as you guys merge #366

@rpereira rpereira mentioned this issue Apr 11, 2016
Merged
@rpereira
Copy link
Author

Fixed by #366 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amadeus @rpereira