chore: use optional catch binding

Author: panva

certification/runner/api.js

@@ -30,7 +30,7 @@ class API {
 
     try {
       assert.equal(response.status, 200);
-    } catch (_err) {
+    } catch {
       throw new Error('unexpected response code', { cause: [response.status, await response.text()] });
     }
 
@@ -58,7 +58,7 @@ class API {
 
     try {
       assert.equal(response.status, 201);
-    } catch (_err) {
+    } catch {
       throw new Error('unexpected response code', { cause: [response.status, await response.text()] });
     }
 
@@ -81,7 +81,7 @@ class API {
 
     try {
       assert.equal(response.status, 201);
-    } catch (_err) {
+    } catch {
       throw new Error('unexpected response code', { cause: [response.status, await response.text()] });
     }
 
@@ -95,7 +95,7 @@ class API {
 
     try {
       assert.equal(response.status, 200);
-    } catch (_err) {
+    } catch {
       throw new Error('unexpected response code', { cause: [response.status, await response.text()] });
     }
 
@@ -109,7 +109,7 @@ class API {
 
     try {
       assert.equal(response.status, 200);
-    } catch (_err) {
+    } catch {
       throw new Error('unexpected response code', { cause: [response.status, await response.text()] });
     }
 
@@ -131,7 +131,7 @@ class API {
 
     try {
       assert.equal(response.status, 200);
-    } catch (_err) {
+    } catch {
       throw new Error('unexpected response code', { cause: [response.status, await response.text()] });
     }
 

lib/actions/authorization/check_claims.js

@@ -28,7 +28,7 @@ export default async function checkClaims(ctx, next) {
 
       try {
         claims = JSON.parse(params.claims);
-      } catch (_err) {
+      } catch {
         throw new InvalidRequest('could not parse the claims parameter JSON');
       }
 

lib/actions/authorization/ciba_load_account.js

@@ -17,7 +17,7 @@ export default async function cibaLoadAccount(ctx, next) {
 
   try {
     ({ 0: [mechanism, value], length } = Object.entries(mechanisms));
-  } catch (_err) {}
+  } catch {}
 
   if (!length) {
     throw new InvalidRequest('missing one of required parameters login_hint_token, id_token_hint, or login_hint');

lib/helpers/oidc_context.js

@@ -233,7 +233,7 @@ export default function getContext(provider) {
 
       try {
         ({ 0: [mechanism, token], length } = Object.entries(mechanisms));
-      } catch (_err) {}
+      } catch {}
 
       if (!length) {
         throw new NoAccessTokenProvided();

lib/helpers/pkce.js

@@ -23,7 +23,7 @@ export default function checkPKCE(verifier, challenge, method) {
       if (!constantEquals(challenge, expected)) {
         throw new Error();
       }
-    } catch (_err) {
+    } catch {
       throw new InvalidGrant('PKCE verification failed');
     }
   }

lib/models/base_model.js

@@ -100,7 +100,7 @@ export default function getBaseModel(provider) {
         const payload = await this.verify(stored, { ignoreExpiration });
 
         return this.instantiate(payload);
-      } catch (_err) {
+      } catch {
         return undefined;
       }
     }

lib/models/device_code.js

@@ -25,7 +25,7 @@ export default (provider) => class DeviceCode extends apply([
         return undefined;
       }
       return this.instantiate(payload);
-    } catch (_err) {
+    } catch {
       return undefined;
     }
   }

lib/models/session.js

@@ -44,7 +44,7 @@ export default (provider) => class Session extends hasFormat(provider, 'Session'
     try {
       const payload = await this.verify(stored);
       return this.instantiate(payload);
-    } catch (_err) {
+    } catch {
       return undefined;
     }
   }

lib/shared/check_rar.js

@@ -21,7 +21,7 @@ export default async function checkRar(ctx, next) {
 
       try {
         details = JSON.parse(params.authorization_details);
-      } catch (_err) {
+      } catch {
         throw new InvalidRequest('could not parse the authorization_details parameter JSON');
       }
 

lib/shared/client_auth.js

@@ -105,7 +105,7 @@ export default function clientAuthentication(provider) {
           try {
             basicClientId = decodeAuthToken(basic.slice(0, i));
             clientSecret = decodeAuthToken(basic.slice(i + 1));
-          } catch (_err) {
+          } catch {
             throw new InvalidRequest('client_id and client_secret in the authorization header are not properly encoded');
           }
 
@@ -120,7 +120,7 @@ export default function clientAuthentication(provider) {
           let sub;
           try {
             ({ payload: { sub } } = JWT.decode(ctx.headers['oauth-client-attestation']));
-          } catch (_err) {
+          } catch {
             throw new InvalidRequest('invalid OAuth-Client-Attestation format');
           }
 
@@ -134,7 +134,7 @@ export default function clientAuthentication(provider) {
           let sub;
           try {
             ({ payload: { sub } } = JWT.decode(ctx.oidc.params.client_assertion));
-          } catch (_err) {
+          } catch {
             throw new InvalidRequest('invalid client_assertion format');
           }