fix: parsing time index column option (GreptimeTeam#865)

* fix: parsing time index column option

* test: adds more cases for creating table

* chore: by CR comments

* feat: validate time index constraint in parser

* chore: improve error msg

Author: killme2008

src/datanode/src/sql/create.rs

@@ -269,24 +269,6 @@ mod tests {
         assert_eq!(4, c.schema.column_schemas().len());
     }
 
-    /// Time index not specified in sql
-    #[tokio::test]
-    pub async fn test_time_index_not_specified() {
-        let handler = create_mock_sql_handler().await;
-        let parsed_stmt = sql_to_statement(
-            r#"create table demo_table(
-                      host string,
-                      ts bigint,
-                      cpu double default 0,
-                      memory double,
-                      PRIMARY KEY(host)) engine=mito with(regions=1);"#,
-        );
-        let error = handler
-            .create_to_request(42, parsed_stmt, TableReference::bare("demo_table"))
-            .unwrap_err();
-        assert_matches!(error, Error::MissingTimestampColumn { .. });
-    }
-
     #[tokio::test]
     pub async fn test_primary_key_not_specified() {
         let handler = create_mock_sql_handler().await;

src/sql/src/error.rs

@@ -64,15 +64,22 @@ pub enum Error {
     #[snafu(display("Tokenizer error, sql: {}, source: {}", sql, source))]
     Tokenizer { sql: String, source: TokenizerError },
 
-    #[snafu(display(
-        "Invalid time index, it should contains only one column, sql: {}.",
-        sql
-    ))]
-    InvalidTimeIndex { sql: String, backtrace: Backtrace },
+    #[snafu(display("Missing time index constraint"))]
+    MissingTimeIndex { backtrace: Backtrace },
+
+    #[snafu(display("Invalid time index: {}", msg))]
+    InvalidTimeIndex { msg: String, backtrace: Backtrace },
 
     #[snafu(display("Invalid SQL, error: {}", msg))]
     InvalidSql { msg: String, backtrace: Backtrace },
 
+    #[snafu(display("Invalid column option, column name: {}, error: {}", name, msg))]
+    InvalidColumnOption {
+        name: String,
+        msg: String,
+        backtrace: Backtrace,
+    },
+
     #[snafu(display("SQL data type not supported yet: {:?}", t))]
     SqlTypeNotSupported {
         t: crate::ast::DataType,
@@ -134,16 +141,18 @@ impl ErrorExt for Error {
             UnsupportedDefaultValue { .. } | Unsupported { .. } => StatusCode::Unsupported,
             Unexpected { .. }
             | Syntax { .. }
+            | MissingTimeIndex { .. }
             | InvalidTimeIndex { .. }
             | Tokenizer { .. }
             | InvalidSql { .. }
             | ParseSqlValue { .. }
             | SqlTypeNotSupported { .. }
             | InvalidDefault { .. } => StatusCode::InvalidSyntax,
 
-            InvalidDatabaseName { .. } | ColumnTypeMismatch { .. } | InvalidTableName { .. } => {
-                StatusCode::InvalidArguments
-            }
+            InvalidColumnOption { .. }
+            | InvalidDatabaseName { .. }
+            | ColumnTypeMismatch { .. }
+            | InvalidTableName { .. } => StatusCode::InvalidArguments,
             UnsupportedAlterTableStatement { .. } => StatusCode::InvalidSyntax,
             SerializeColumnDefaultConstraint { source, .. } => source.status_code(),
             ConvertToGrpcDataType { source, .. } => source.status_code(),