Skip to content

Commit 0708318

Browse files
committed
hotfix: disable semantic tokens by default, make release
1 parent 0e792a5 commit 0708318

5 files changed

Lines changed: 37 additions & 31 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## 0.45.1
8+
9+
### Fixed
10+
11+
- Disable semantic tokens by default because they are currently broken. Works around this issue: <https://github.com/pappasam/jedi-language-server/issues/340>
12+
713
## 0.45.0
814

915
### Added

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ See: <https://github.com/pappasam/jedi-language-server/issues/50#issuecomment-78
100100
}
101101
},
102102
"semanticTokens": {
103-
"enable": true
103+
"enable": false
104104
}
105105
}
106106
}
@@ -199,7 +199,7 @@ A list of regular expressions. If any regular expression in ignorePatterns match
199199
- type: `string[]`
200200
- default: `[]`
201201

202-
In general, you should prefer the default value for this option. Jedi is very good at filtering values for end users. That said, there are situations where IDE developers, or some programmers in some code bases, may want to filter some completions by name. This flexible interface is provided to accommodate these advanced use cases. If you have one of these advanced use cases, see below for some example patterns (and their corresponding regular expression).
202+
In general, you should prefer the default value for this option. Jedi is good at filtering values for end users. That said, there are situations where IDE developers, or some programmers in some codebases, may want to filter some completions by name. This flexible interface is provided to accommodate these advanced use cases. If you have one of these advanced use cases, see below for some example patterns (and their corresponding regular expression).
203203

204204
#### All Private Names
205205

@@ -265,7 +265,7 @@ When diagnostics are enabled, run on document open
265265

266266
### diagnostics.didChange
267267

268-
When diagnostics are enabled, run on in-memory document change (eg, while you're editing, without needing to save to disk)
268+
When diagnostics are enabled, run on in-memory document change (e.g., while you're editing, without needing to save to disk)
269269

270270
- type: `boolean`
271271
- default: `true`
@@ -416,10 +416,10 @@ If you manually set this option, it overrides the default. Setting it to an empt
416416

417417
### semanticTokens.enable
418418

419-
Improves highlighting by providing semantic token information.
419+
Improves highlighting by providing semantic token information. Disabled by default, because feature is broken and currently under development.
420420

421421
- type: `boolean`
422-
- default: `true`
422+
- default: `false`
423423

424424
## Diagnostics
425425

@@ -475,7 +475,7 @@ jedi-language-server aims to support Jedi's capabilities and expose them through
475475
- [textDocument/publishDiagnostics](https://microsoft.github.io/language-server-protocol/specification#textDocument_publishDiagnostics)
476476
- [textDocument/references](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_references)
477477
- [textDocument/rename](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_rename)
478-
- [textDocument/semanticTokens](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_semanticTokens)
478+
- [textDocument/semanticTokens](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_semanticTokens) _(under development)_
479479
- [textDocument/signatureHelp](https://microsoft.github.io/language-server-protocol/specification#textDocument_signatureHelp)
480480
- [workspace/symbol](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_symbol)
481481

jedi_language_server/initialization_options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class Workspace:
9999

100100
@light_dataclass
101101
class SemanticTokens:
102-
enable: bool = True
102+
enable: bool = False
103103

104104

105105
@light_dataclass

poetry.lock

Lines changed: 23 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ ignore_missing_imports = true
1313

1414
[tool.poetry]
1515
name = "jedi-language-server"
16-
version = "0.45.0"
16+
version = "0.45.1"
1717
description = "A language server for Jedi!"
1818
authors = ["Sam Roeca <samuel.roeca@gmail.com>"]
1919
readme = "README.md"

0 commit comments

Comments
 (0)