Skip to content

Commit ec3d52b

Browse files
authored
Updated electron to latest 36.4.0, updated node to 22.14.0 (#1644)
* Updated electron to latest 36.4.0, updated node to 22.14.0 * Fixed PlatformError bug that happened as a result of changing Error implementation in Node 22.14.0
1 parent b4d4f88 commit ec3d52b

File tree

10 files changed

+587
-593
lines changed

10 files changed

+587
-593
lines changed

electron-builder.json5

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
],
5757
},
5858
linux: {
59+
executableName: 'platform-bible',
5960
target: ['snap'],
6061
category: 'Development',
6162
extraResources: [

extensions/src/paratext-registration/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,6 @@
9292
"zip-build": "^1.8.0"
9393
},
9494
"volta": {
95-
"node": "20.18.0"
95+
"extends": "../../package.json"
9696
}
9797
}

extensions/src/platform-lexical-tools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,6 @@
9494
"zip-build": "^1.8.0"
9595
},
9696
"volta": {
97-
"node": "20.18.0"
97+
"extends": "../../package.json"
9898
}
9999
}

lib/platform-bible-utils/dist/index.cjs

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

lib/platform-bible-utils/dist/index.cjs.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/platform-bible-utils/dist/index.js

Lines changed: 35 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/platform-bible-utils/dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/platform-bible-utils/src/platform-error.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,12 @@ export function newPlatformError(error?: unknown): PlatformError {
5050
};
5151
Object.defineProperties(platformError, Object.getOwnPropertyDescriptors(error));
5252
Object.defineProperty(platformError, 'message', { enumerable: true });
53-
if ('stack' in platformError)
54-
Object.defineProperty(platformError, 'stack', { enumerable: true });
53+
if ('stack' in error && isString(error.stack)) {
54+
// stack is generated lazily, and it seems this is causing some troubles with copying it into
55+
// another object via property descriptors as of Node 22.14.0 (no problems in 20.18.0).
56+
// So we shall set the value directly on the object
57+
Object.defineProperty(platformError, 'stack', { value: error.stack, enumerable: true });
58+
}
5559
if ('cause' in platformError)
5660
Object.defineProperty(platformError, 'cause', { enumerable: true });
5761
return platformError;

0 commit comments

Comments
 (0)