Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Commit 504859a

Browse files
committed
Fix BridgePalletIsNotInitialized
1 parent 30f2866 commit 504859a

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

parachains/runtimes/bridge-hubs/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,20 +126,20 @@ RUST_LOG=runtime=trace,rpc=trace,bridge=trace \
126126
~/local_bridge_testing/bin/substrate-relay relay-headers-and-messages bridge-hub-rococo-bridge-hub-wococo \
127127
--rococo-host localhost \
128128
--rococo-port 9942 \
129-
--rococo-version-mode Auto \
129+
--rococo-version-mode Auto \
130130
--bridge-hub-rococo-host localhost \
131131
--bridge-hub-rococo-port 8943 \
132-
--bridge-hub-rococo-version-mode Auto \
132+
--bridge-hub-rococo-version-mode Auto \
133133
--bridge-hub-rococo-signer //Charlie \
134134
--wococo-headers-to-bridge-hub-rococo-signer //Bob \
135135
--wococo-parachains-to-bridge-hub-rococo-signer //Bob \
136136
--bridge-hub-rococo-transactions-mortality 4 \
137137
--wococo-host localhost \
138138
--wococo-port 9945 \
139-
--wococo-version-mode Auto \
139+
--wococo-version-mode Auto \
140140
--bridge-hub-wococo-host localhost \
141141
--bridge-hub-wococo-port 8945 \
142-
--bridge-hub-wococo-version-mode Auto \
142+
--bridge-hub-wococo-version-mode Auto \
143143
--bridge-hub-wococo-signer //Charlie \
144144
--rococo-headers-to-bridge-hub-wococo-signer //Bob \
145145
--rococo-parachains-to-bridge-hub-wococo-signer //Bob \

parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ mod weights;
3030
pub mod xcm_config;
3131

3232
use bridge_common_config::*;
33-
use codec::Decode;
3433
use constants::currency::*;
3534
use cumulus_pallet_parachain_system::RelayNumberStrictlyIncreases;
3635
use sp_api::impl_runtime_apis;
@@ -64,7 +63,7 @@ pub use sp_runtime::{MultiAddress, Perbill, Permill};
6463
use xcm_config::{XcmConfig, XcmOriginToTransactDispatchOrigin};
6564

6665
use bp_parachains::SingleParaStoredHeaderDataBuilder;
67-
use bp_runtime::{HeaderId, HeaderIdProvider};
66+
use bp_runtime::HeaderId;
6867

6968
#[cfg(any(feature = "std", test))]
7069
pub use sp_runtime::BuildStorage;
@@ -722,17 +721,17 @@ impl_runtime_apis! {
722721

723722
impl bp_bridge_hub_rococo::BridgeHubRococoFinalityApi<Block> for Runtime {
724723
fn best_finalized() -> Option<HeaderId<Hash, BlockNumber>> {
725-
let encoded_head = BridgeRococoParachain::best_parachain_head(bp_bridge_hub_rococo::BRIDGE_HUB_ROCOCO_PARACHAIN_ID.into())?;
726-
let head = bp_bridge_hub_rococo::Header::decode(&mut &encoded_head.0[..]).ok()?;
727-
Some(head.id())
724+
BridgeRococoParachain::best_parachain_head_id::<
725+
bp_bridge_hub_rococo::BridgeHubRococo
726+
>().unwrap_or(None)
728727
}
729728
}
730729

731730
impl bp_bridge_hub_wococo::BridgeHubWococoFinalityApi<Block> for Runtime {
732731
fn best_finalized() -> Option<HeaderId<Hash, BlockNumber>> {
733-
let encoded_head = BridgeWococoParachain::best_parachain_head(bp_bridge_hub_wococo::BRIDGE_HUB_WOCOCO_PARACHAIN_ID.into())?;
734-
let head = bp_bridge_hub_wococo::Header::decode(&mut &encoded_head.0[..]).ok()?;
735-
Some(head.id())
732+
BridgeWococoParachain::best_parachain_head_id::<
733+
bp_bridge_hub_wococo::BridgeHubWococo
734+
>().unwrap_or(None)
736735
}
737736
}
738737

0 commit comments

Comments
 (0)