feat: client rpc middleware (#1521)

* feat: client rpc middleware

* PoC works

* cargo fmt

* more refactoring

* use Cow in Notification to avoid alloc

* cleanup some todos

* rpc trait: return Result<MethodResponse, Err>

* remove infallible err

* make it compile

* fix tests

* introduce client method response type

* fix faulty imports

* minor cleanup

* introduce Batch/BatchEntry for middleware

* remove ignore for batch test

* fix rustdocs

* add rpc middleware for the async client

* remove serialize specific types

* commit missing file

* no serde_json::Value

* more nit fixing

* more cleanup

* refactor method response client

* fix some nits

* add client middleware rpc

* fix wasm build

* add client middleware example

* Update examples/examples/rpc_middleware_client.rs

* ToJson -> RawValue

* replace Future type with impl Trait

* revert changelog

* remove logger response future

* some cleanup

* move request timeout from transport to client

* more nit fixing

* have pass over examples

* show proper batch middleware example

* middleware: clean up batch type

* fix wasm build

* Update Cargo.toml

* doc: fix typo

* core: remove tracing mod

* fix more clippy

* remove middleware error

* address review grumbles

* fix tests

* fix tests

* ErrorResponse -> BatchEntryErr

* commit missing file

* move deserialize_with_ext to server again

* Update core/src/client/mod.rs

Co-authored-by: Copilot <[email protected]>

* client: enable default rpc logger

---------

Co-authored-by: Copilot <[email protected]>

Author: niklasad1

Cargo.toml

@@ -98,3 +98,6 @@ rust_2024_compatibility = { level = "warn", priority = -1 }
 missing_docs = { level = "warn", priority = -1 }
 missing_debug_implementations = { level = "warn", priority = -1 }
 missing_copy_implementations = { level = "warn", priority = -1 }
+
+[workspace.lints.clippy]
+manual_async_fn = { level = "allow", priority = -1 }

benches/bench.rs

@@ -9,7 +9,7 @@ use helpers::fixed_client::{
 	ws_handshake,
 };
 use helpers::{KIB, SUB_METHOD_NAME, UNSUB_METHOD_NAME};
-use jsonrpsee::types::{Id, RequestSer};
+use jsonrpsee::types::{Id, Request};
 use pprof::criterion::{Output, PProfProfiler};
 use tokio::runtime::Runtime as TokioRuntime;
 
@@ -101,7 +101,7 @@ impl RequestType {
 	}
 }
 
-fn v2_serialize(req: RequestSer<'_>) -> String {
+fn v2_serialize(req: Request<'_>) -> String {
 	serde_json::to_string(&req).unwrap()
 }
 
@@ -115,7 +115,7 @@ pub fn jsonrpsee_types_v2(crit: &mut Criterion) {
 		b.iter(|| {
 			let params = serde_json::value::RawValue::from_string("[1, 2]".to_string()).unwrap();
 
-			let request = RequestSer::borrowed(&Id::Number(0), &"say_hello", Some(&params));
+			let request = Request::borrowed("say_hello", Some(&params), Id::Number(0));
 			v2_serialize(request);
 		})
 	});
@@ -128,7 +128,7 @@ pub fn jsonrpsee_types_v2(crit: &mut Criterion) {
 			builder.insert(1u64).unwrap();
 			builder.insert(2u32).unwrap();
 			let params = builder.to_rpc_params().expect("Valid params");
-			let request = RequestSer::borrowed(&Id::Number(0), &"say_hello", params.as_deref());
+			let request = Request::borrowed("say_hello", params.as_deref(), Id::Number(0));
 			v2_serialize(request);
 		})
 	});
@@ -138,7 +138,7 @@ pub fn jsonrpsee_types_v2(crit: &mut Criterion) {
 		b.iter(|| {
 			let params = serde_json::value::RawValue::from_string(r#"{"key": 1}"#.to_string()).unwrap();
 
-			let request = RequestSer::borrowed(&Id::Number(0), &"say_hello", Some(&params));
+			let request = Request::borrowed("say_hello", Some(&params), Id::Number(0));
 			v2_serialize(request);
 		})
 	});
@@ -150,7 +150,7 @@ pub fn jsonrpsee_types_v2(crit: &mut Criterion) {
 			let mut builder = ObjectParams::new();
 			builder.insert("key", 1u32).unwrap();
 			let params = builder.to_rpc_params().expect("Valid params");
-			let request = RequestSer::borrowed(&Id::Number(0), &"say_hello", params.as_deref());
+			let request = Request::borrowed("say_hello", params.as_deref(), Id::Number(0));
 			v2_serialize(request);
 		})
 	});

client/http-client/Cargo.toml

@@ -31,7 +31,6 @@ serde = { workspace = true }
 serde_json = { workspace = true }
 thiserror = { workspace = true }
 tokio = { workspace = true, features = ["time"] }
-tracing = { workspace = true }
 tower = { workspace = true, features = ["util"] }
 url = { workspace = true }