Skip to content

Commit 5c69aaf

Browse files
clangenbgithub-actions[bot]acatangiu
authored andcommitted
[frame-support] remove error reporting in remote_transfer_xcm for paid execution (#10697)
The reason is that it is broken and will result in spamming errors until we fix it properly: #10078. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>
1 parent a62446d commit 5c69aaf

3 files changed

Lines changed: 12 additions & 11 deletions

File tree

polkadot/xcm/xcm-builder/src/tests/pay/transfer.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,6 @@ fn remote_transfer_xcm<Call>(
166166
WithdrawAsset(fee_asset.clone().into()),
167167
PayFees { asset: fee_asset.clone() },
168168
SetAppendix(Xcm(vec![
169-
ReportError(QueryResponseInfo {
170-
destination: (Parent, Parachain(MockRuntimeParachainId::get().into())).into(),
171-
query_id: 1,
172-
max_weight: Weight::MAX,
173-
}),
174169
RefundSurplus,
175170
DepositAsset {
176171
assets: AssetFilter::Wild(WildAsset::All),

polkadot/xcm/xcm-builder/src/transfer.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ fn remote_transfer_xcm_paying_fees(
332332
asset_id: AssetId,
333333
amount: u128,
334334
remote_fee: Asset,
335-
query_id: QueryId,
335+
_: QueryId,
336336
) -> Result<Xcm<()>, Error> {
337337
// Transform `from` into Location::new(1, XX([Parachain(source), from.interior }])
338338
// We need this one for the refunds.
@@ -346,11 +346,7 @@ fn remote_transfer_xcm_paying_fees(
346346
WithdrawAsset(vec![remote_fee.clone()].into()),
347347
PayFees { asset: remote_fee },
348348
SetAppendix(Xcm(vec![
349-
ReportError(QueryResponseInfo {
350-
destination: origin_relative_to_remote.clone(),
351-
query_id,
352-
max_weight: Weight::MAX,
353-
}),
349+
// Todo: add error reporting after fixing https://github.com/paritytech/polkadot-sdk/issues/10078
354350
RefundSurplus,
355351
DepositAsset { assets: AssetFilter::Wild(WildAsset::All), beneficiary: from_at_target },
356352
])),

prdoc/pr_10697.prdoc

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
title: '[frame-support] remove error reporting in `remote_transfer_xcm` for paid execution'
2+
doc:
3+
- audience:
4+
- Runtime Dev
5+
- Runtime User
6+
description: 'The reason is that it is broken and will result in spamming errors
7+
until we fix it properly: https://github.com/paritytech/polkadot-sdk/issues/10078.'
8+
crates:
9+
- name: staging-xcm-builder
10+
bump: patch

0 commit comments

Comments
 (0)