[frame-support] remove error reporting in remote_transfer_xcm for paid execution (#10697)

The reason is that it is broken and will result in spamming errors until
we fix it properly:
#10078.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>

Author: 3 people

polkadot/xcm/xcm-builder/src/tests/pay/transfer.rs

@@ -166,11 +166,6 @@ fn remote_transfer_xcm<Call>(
 		WithdrawAsset(fee_asset.clone().into()),
 		PayFees { asset: fee_asset.clone() },
 		SetAppendix(Xcm(vec![
-			ReportError(QueryResponseInfo {
-				destination: (Parent, Parachain(MockRuntimeParachainId::get().into())).into(),
-				query_id: 1,
-				max_weight: Weight::MAX,
-			}),
 			RefundSurplus,
 			DepositAsset {
 				assets: AssetFilter::Wild(WildAsset::All),

polkadot/xcm/xcm-builder/src/transfer.rs

@@ -332,7 +332,7 @@ fn remote_transfer_xcm_paying_fees(
 	asset_id: AssetId,
 	amount: u128,
 	remote_fee: Asset,
-	query_id: QueryId,
+	_: QueryId,
 ) -> Result<Xcm<()>, Error> {
 	// Transform `from` into Location::new(1, XX([Parachain(source), from.interior }])
 	// We need this one for the refunds.
@@ -346,11 +346,7 @@ fn remote_transfer_xcm_paying_fees(
 		WithdrawAsset(vec![remote_fee.clone()].into()),
 		PayFees { asset: remote_fee },
 		SetAppendix(Xcm(vec![
-			ReportError(QueryResponseInfo {
-				destination: origin_relative_to_remote.clone(),
-				query_id,
-				max_weight: Weight::MAX,
-			}),
+			// Todo: add error reporting after fixing https://github.com/paritytech/polkadot-sdk/issues/10078
 			RefundSurplus,
 			DepositAsset { assets: AssetFilter::Wild(WildAsset::All), beneficiary: from_at_target },
 		])),

prdoc/pr_10697.prdoc

@@ -0,0 +1,10 @@
+title: '[frame-support] remove error reporting in `remote_transfer_xcm` for paid execution'
+doc:
+- audience:
+  - Runtime Dev
+  - Runtime User
+  description: 'The reason is that it is broken and will result in spamming errors
+    until we fix it properly: https://github.com/paritytech/polkadot-sdk/issues/10078.'
+crates:
+- name: staging-xcm-builder
+  bump: patch