Skip to content

Commit 9144026

Browse files
authored
Zombienet CI improvements (#12372)
- Fix loki url - Add debug for sending logs to loki - Add retries for additional setup.
1 parent bcafdb3 commit 9144026

4 files changed

Lines changed: 13 additions & 10 deletions

File tree

.github/scripts/process-logs-zombienet.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@ set -euo pipefail
44
# This script processes logs produced by nodes spawned using the zombienet-sdk framework.
55
# The logs are prepared for upload as GitHub artifacts.
66
# If Loki logging is available, the corresponding log URLs are also printed.
7-
# NOTE: P2838773B5F7DE937 is the loki.cicd until we switch to loki.zombienet
8-
LOKI_URL_FOR_NODE='https://grafana.teleport.parity.io/explore?orgId=1&left=%7B%22datasource%22:%22P2838773B5F7DE937%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%22P2838773B5F7DE937%22%7D,%22editorMode%22:%22code%22,%22expr%22:%22%7Bzombie_ns%3D%5C%22{{namespace}}%5C%22,zombie_node%3D%5C%22{{podName}}%5C%22%7D%22,%22queryType%22:%22range%22%7D%5D,%22range%22:%7B%22from%22:%22{{from}}%22,%22to%22:%22{{to}}%22%7D%7D'
7+
# NOTE: P982945308D3682D1 is the loki until we switch to loki.zombienet
8+
LOKI_URL_FOR_NODE='https://grafana.teleport.parity.io/explore?schemaVersion=1&panes=%7B%22vxs%22:%7B%22datasource%22:%22P982945308D3682D1%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22%7Bzombie_ns%3D%5C%22{{namespace}}%5C%22,zombie_node%3D%5C%22{{podName}}%5C%22%7D%22,%22queryType%22:%22range%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%22P982945308D3682D1%22%7D,%22editorMode%22:%22code%22,%22direction%22:%22forward%22%7D%5D,%22range%22:%7B%22from%22:%22{{from}}%22,%22to%22:%22{{to}}%22%7D,%22compact%22:false%7D%7D&orgId=1'
99

10+
# Directory to send logs to loki
1011
LOKI_DIR_FOR_NATIVE_LOGS="/var/log/shared/zombienet"
1112

1213
# JQ queries
@@ -89,6 +90,7 @@ process_logs_from_fallback() {
8990
# Send logs to loki
9091
if [[ -d "$LOKI_DIR_FOR_NATIVE_LOGS" ]]; then
9192
if [[ -f "$TARGET_DIR/$name.log" ]]; then
93+
echo -e "sending logs to loki file: $LOKI_DIR_FOR_NATIVE_LOGS/to-loki.log"
9294
awk -v NS="$NS" -v NAME="$name" '{print NS" "NAME" " $0}' "$TARGET_DIR/$name.log" >> "$LOKI_DIR_FOR_NATIVE_LOGS/to-loki.log"
9395
local_to=$(($(date +%s%3N) + 60000))
9496
fi
@@ -172,6 +174,7 @@ process_logs_from_zombie_file() {
172174

173175
# send logs to loki
174176
if [[ -d "$LOKI_DIR_FOR_NATIVE_LOGS" && -f "$TARGET_DIR/$name.log" ]]; then
177+
echo -e "[para] sending logs to loki file: $LOKI_DIR_FOR_NATIVE_LOGS/to-loki.log"
175178
awk -v NS="$NS" -v NAME="$name" '{print NS" "NAME" " $0}' "$TARGET_DIR/$name.log" >> "$LOKI_DIR_FOR_NATIVE_LOGS/to-loki.log"
176179
local_to=$(($(date +%s%3N) + 60000))
177180
fi

.github/workflows/zombienet-reusable-preflight.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ jobs:
347347
cat .github/zombienet-flaky-tests
348348
349349
#
350-
#
350+
# Set docker images
351351
#
352352
- name: Set docker images version
353353
id: set_images_version

.github/zombienet-tests/zombienet_polkadot_tests.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@
4343
for bin in polkadot polkadot-parachain; do
4444
OLD_NAME="$bin-old"
4545
echo "downloading $bin as $OLD_NAME in $BIN_DIR";
46-
curl -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-v1.7.0/$bin
46+
curl --retry 5 --retry-delay 10 --retry-max-time 120 -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-v1.7.0/$bin
4747
chmod 755 $BIN_DIR/$OLD_NAME;
4848
done
4949
for bin in polkadot-execute-worker polkadot-prepare-worker; do
5050
OLD_NAME="$bin"
5151
echo "downloading $bin as $OLD_NAME in $BIN_DIR";
52-
curl -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-v1.7.0/$bin
52+
curl --retry 5 --retry-delay 10 --retry-max-time 120 -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-v1.7.0/$bin
5353
chmod 755 $BIN_DIR/$OLD_NAME;
5454
done
5555
ls -ltr $BIN_DIR
@@ -178,13 +178,13 @@
178178
for bin in polkadot polkadot-parachain; do
179179
OLD_NAME="$bin-old"
180180
echo "downloading $bin as $OLD_NAME in $BIN_DIR";
181-
curl -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2503/$bin
181+
curl --retry 5 --retry-delay 10 --retry-max-time 120 -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2503/$bin
182182
chmod 755 $BIN_DIR/$OLD_NAME;
183183
done
184184
for bin in polkadot-execute-worker polkadot-prepare-worker; do
185185
OLD_NAME="$bin"
186186
echo "downloading $bin as $OLD_NAME in $BIN_DIR";
187-
curl -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2503/$bin
187+
curl --retry 5 --retry-delay 10 --retry-max-time 120 -L -o $BIN_DIR/$OLD_NAME https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2503/$bin
188188
chmod 755 $BIN_DIR/$OLD_NAME;
189189
done
190190
ls -ltr $BIN_DIR
@@ -245,11 +245,11 @@
245245
BIN_DIR="$(pwd)/bin_old"
246246
mkdir -p $BIN_DIR
247247
echo "downloading polkadot as polkadot-old in $BIN_DIR"
248-
curl -L -o $BIN_DIR/polkadot-old https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2512/polkadot
248+
curl --retry 5 --retry-delay 10 --retry-max-time 120 -L -o $BIN_DIR/polkadot-old https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2512/polkadot
249249
chmod 755 $BIN_DIR/polkadot-old
250250
for bin in polkadot-execute-worker polkadot-prepare-worker; do
251251
echo "downloading $bin in $BIN_DIR"
252-
curl -L -o $BIN_DIR/$bin https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2512/$bin
252+
curl --retry 5 --retry-delay 10 --retry-max-time 120 -L -o $BIN_DIR/$bin https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2512/$bin
253253
chmod 755 $BIN_DIR/$bin
254254
done
255255
ls -ltr $BIN_DIR

polkadot/zombienet-sdk-tests/tests/functional/approved_peer_mixed_validators.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ async fn approved_peer_mixed_validators_test() -> Result<(), anyhow::Error> {
113113
assert_para_throughput(
114114
&relay_client,
115115
15,
116-
[(ParaId::from(2000), 6..15), (ParaId::from(2001), 11..16)],
116+
[(ParaId::from(2000), 6..16), (ParaId::from(2001), 11..16)],
117117
[],
118118
)
119119
.await?;

0 commit comments

Comments
 (0)