From 63bf066bd12aaaedba2b3d16c8fc3d1301bd2582 Mon Sep 17 00:00:00 2001 From: Iulian Barbu Date: Tue, 10 Jun 2025 12:53:28 +0000 Subject: [PATCH 1/2] add features option for macos binaries too Signed-off-by: Iulian Barbu --- .github/scripts/release/build-macos-release.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/scripts/release/build-macos-release.sh b/.github/scripts/release/build-macos-release.sh index ba6dcc65d6509..4edb6746d73f5 100755 --- a/.github/scripts/release/build-macos-release.sh +++ b/.github/scripts/release/build-macos-release.sh @@ -14,12 +14,17 @@ PROFILE=${PROFILE:-production} # write, so make it relative to github workspace. ARTIFACTS=$GITHUB_WORKSPACE/artifacts/$BIN VERSION=$(git tag -l --contains HEAD | grep -E "^v.*") +# must be given as feature1,feature2,feature3... +FEATURES=$3 +if [ -n "$FEATURES" ]; then + FEATURES="--features ${FEATURES}" +fi echo "Artifacts will be copied into $ARTIFACTS" mkdir -p "$ARTIFACTS" git log --pretty=oneline -n 1 -time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE +time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE $FEATURES echo "Artifact target: $ARTIFACTS" From d30c1f48cf00c421dd51eabc8012ad48470a0d26 Mon Sep 17 00:00:00 2001 From: Iulian Barbu Date: Tue, 10 Jun 2025 18:02:37 +0000 Subject: [PATCH 2/2] fix macos build Signed-off-by: Iulian Barbu --- .github/workflows/release-reusable-rc-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-reusable-rc-build.yml b/.github/workflows/release-reusable-rc-build.yml index f33c18087e635..e7c0ed48e4706 100644 --- a/.github/workflows/release-reusable-rc-build.yml +++ b/.github/workflows/release-reusable-rc-build.yml @@ -209,7 +209,7 @@ jobs: - name: Install pgpkkms run: | # Install pgpkms that is used to sign built artifacts - python3 -m pip install "pgpkms @ git+https://github.com/paritytech-release/pgpkms.git@e7f806f99e9be5c52f0b4a536b7d4ef9c3e695ed" + python3 -m pip install "pgpkms @ git+https://github.com/paritytech-release/pgpkms.git@e7f806f99e9be5c52f0b4a536b7d4ef9c3e695ed" --break-system-packages - name: Import gpg keys shell: bash