add a comment and search logs on all nodes

Andronik · Andronik · commit cfe4be4165c1 · 2023-05-24T11:00:19.000+02:00
diff --git a/node/core/dispute-coordinator/src/initialized.rs b/node/core/dispute-coordinator/src/initialized.rs
@@ -440,6 +440,8 @@ impl Initialized {
 				}
 
 				if !key_ownership_proofs.is_empty() {
+					// If we found a parent that we can use, stop searching.
+					// If one key ownership was resolved successfully, all of them should be.
 					debug_assert_eq!(key_ownership_proofs.len(), pending.keys.len());
 					break
 				}
diff --git a/zombienet_tests/functional/0004-parachains-disputes-past-session.zndsl b/zombienet_tests/functional/0004-parachains-disputes-past-session.zndsl
@@ -34,5 +34,4 @@ honest-validator-0: reports parachain_candidate_dispute_concluded{validity="inva
 honest-validator-0: reports parachain_candidate_dispute_concluded{validity="valid"} is 0
 
 # Check an unsigned extrinsic is submitted
-# TODO: how to match on all honest validator logs?
-honest-validator-0: log line contains "Successfully reported pending slash" within 180 seconds
+honest-validator: log line contains "Successfully reported pending slash" within 180 seconds

Original file line number	Diff line number	Diff line change
`@@ -440,6 +440,8 @@ impl Initialized {`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`if !key_ownership_proofs.is_empty() {`
	`443`	`+ // If we found a parent that we can use, stop searching.`
	`444`	`+ // If one key ownership was resolved successfully, all of them should be.`
`443`	`445`	`debug_assert_eq!(key_ownership_proofs.len(), pending.keys.len());`
`444`	`446`	`break`
`445`	`447`	`}`