Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Commit e5abe55

Browse files
Warn about usage of pallet collective set members call. (#10156)
* warn * Apply suggestions from code review Co-authored-by: joe petrowski <[email protected]> * fmt Co-authored-by: joe petrowski <[email protected]>
1 parent dc89925 commit e5abe55

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

frame/collective/src/lib.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,13 @@ pub mod pallet {
345345
/// NOTE: Does not enforce the expected `MaxMembers` limit on the amount of members, but
346346
/// the weight estimations rely on it to estimate dispatchable weight.
347347
///
348+
/// # WARNING:
349+
///
350+
/// The `pallet-collective` can also be managed by logic outside of the pallet through the
351+
/// implementation of the trait [`ChangeMembers`].
352+
/// Any call to `set_members` must be careful that the member set doesn't get out of sync
353+
/// with other logic managing the member set.
354+
///
348355
/// # <weight>
349356
/// ## Weight
350357
/// - `O(MP + N)` where:

0 commit comments

Comments
 (0)