fix: Cloud trigger type errors for void returns and subclass constructors (#2904)

Author: swittk

src/CloudCode.ts

@@ -1,8 +1,12 @@
+/* eslint-disable @typescript-eslint/no-invalid-void-type -- Cloud trigger handlers legitimately return void | T */
+
 import type ParseObject from './ParseObject';
 import type ParseUser from './ParseUser';
 import type ParseFile from './ParseFile';
 import type ParseQuery from './ParseQuery';
 
+type ParseObjectConstructor<T extends ParseObject = ParseObject> = new (...args: any[]) => T;
+
 /**
  * @typedef Parse.Cloud.FunctionRequest
  * @property {string} installationId If set, the installationId triggering the request.
@@ -282,8 +286,8 @@ export declare function job(name: string, handler: (request: JobRequest) => any)
  * @param validator An optional function to validate the request
  */
 export declare function beforeSave<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: BeforeSaveRequest<T>) => T | undefined | Promise<T | undefined>,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: BeforeSaveRequest<T>) => void | T | undefined | Promise<void | T | undefined>,
   validator?: ValidatorObject | ((request: BeforeSaveRequest<T>) => any)
 ): void;
 
@@ -310,8 +314,8 @@ export declare function beforeSave<T extends ParseObject = ParseObject>(
  * @param validator An optional function to validate the request
  */
 export declare function afterSave<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: AfterSaveRequest<T>) => Promise<void> | undefined,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: AfterSaveRequest<T>) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: AfterSaveRequest<T>) => any)
 ): void;
 
@@ -338,8 +342,8 @@ export declare function afterSave<T extends ParseObject = ParseObject>(
  * @param validator An optional function to validate the request
  */
 export declare function beforeDelete<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: BeforeDeleteRequest<T>) => Promise<void> | undefined,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: BeforeDeleteRequest<T>) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: BeforeDeleteRequest<T>) => any)
 ): void;
 
@@ -366,8 +370,8 @@ export declare function beforeDelete<T extends ParseObject = ParseObject>(
  * @param validator An optional function to validate the request
  */
 export declare function afterDelete<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: AfterDeleteRequest<T>) => Promise<void> | undefined,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: AfterDeleteRequest<T>) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: AfterDeleteRequest<T>) => any)
 ): void;
 
@@ -381,8 +385,12 @@ export declare function afterDelete<T extends ParseObject = ParseObject>(
  * @param validator An optional function to validate the request
  */
 export declare function beforeFind<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: BeforeFindRequest<T>) => ParseQuery<T> | undefined | Promise<ParseQuery<T> | undefined>,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: BeforeFindRequest<T>) =>
+    | void
+    | ParseQuery<T>
+    | undefined
+    | Promise<void | ParseQuery<T> | undefined>,
   validator?: ValidatorObject | ((request: BeforeFindRequest<T>) => any)
 ): void;
 
@@ -396,8 +404,8 @@ export declare function beforeFind<T extends ParseObject = ParseObject>(
  * @param validator An optional function to validate the request
  */
 export declare function afterFind<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: AfterFindRequest<T>) => T[] | undefined | Promise<T[] | undefined>,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: AfterFindRequest<T>) => void | T[] | undefined | Promise<void | T[] | undefined>,
   validator?: ValidatorObject | ((request: AfterFindRequest<T>) => any)
 ): void;
 
@@ -410,7 +418,7 @@ export declare function afterFind<T extends ParseObject = ParseObject>(
  * @param validator An optional function to validate the request
  */
 export declare function beforeLogin(
-  handler: (request: TriggerRequest<ParseUser>) => Promise<void> | undefined,
+  handler: (request: TriggerRequest<ParseUser>) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: TriggerRequest<ParseUser>) => any)
 ): void;
 
@@ -422,7 +430,7 @@ export declare function beforeLogin(
  * @param handler The function to run after a login.
  */
 export declare function afterLogin(
-  handler: (request: TriggerRequest<ParseUser>) => Promise<void> | undefined
+  handler: (request: TriggerRequest<ParseUser>) => void | Promise<void> | undefined
 ): void;
 
 /**
@@ -433,7 +441,7 @@ export declare function afterLogin(
  * @param handler The function to run after a logout.
  */
 export declare function afterLogout(
-  handler: (request: TriggerRequest) => Promise<void> | undefined
+  handler: (request: TriggerRequest) => void | Promise<void> | undefined
 ): void;
 
 /**
@@ -445,7 +453,7 @@ export declare function afterLogout(
  * @param validator An optional function to validate the request
  */
 export declare function beforePasswordResetRequest(
-  handler: (request: TriggerRequest<ParseUser>) => Promise<void> | undefined,
+  handler: (request: TriggerRequest<ParseUser>) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: TriggerRequest<ParseUser>) => any)
 ): void;
 
@@ -466,7 +474,11 @@ export declare function beforePasswordResetRequest(
  * @param handler The function to run before a file saves.
  */
 export declare function beforeSaveFile(
-  handler: (request: FileTriggerRequest) => ParseFile | undefined | Promise<ParseFile | undefined>
+  handler: (request: FileTriggerRequest) =>
+    | void
+    | ParseFile
+    | undefined
+    | Promise<void | ParseFile | undefined>
 ): void;
 
 /**
@@ -486,7 +498,7 @@ export declare function beforeSaveFile(
  * @param handler The function to run after a file saves.
  */
 export declare function afterSaveFile(
-  handler: (request: FileTriggerRequest) => Promise<void> | undefined
+  handler: (request: FileTriggerRequest) => void | Promise<void> | undefined
 ): void;
 
 /**
@@ -497,7 +509,7 @@ export declare function afterSaveFile(
  * @param handler The function to run before a file is deleted.
  */
 export declare function beforeDeleteFile(
-  handler: (request: FileTriggerRequest) => Promise<void> | undefined
+  handler: (request: FileTriggerRequest) => void | Promise<void> | undefined
 ): void;
 
 /**
@@ -508,7 +520,7 @@ export declare function beforeDeleteFile(
  * @param handler The function to run after a file is deleted.
  */
 export declare function afterDeleteFile(
-  handler: (request: FileTriggerRequest) => Promise<void> | undefined
+  handler: (request: FileTriggerRequest) => void | Promise<void> | undefined
 ): void;
 
 /**
@@ -528,7 +540,7 @@ export declare function afterDeleteFile(
  * @param validator An optional function to validate the request
  */
 export declare function beforeConnect(
-  handler: (request: ConnectTriggerRequest) => Promise<void> | undefined,
+  handler: (request: ConnectTriggerRequest) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: ConnectTriggerRequest) => any)
 ): void;
 
@@ -552,8 +564,8 @@ export declare function beforeConnect(
  * @param validator An optional function to validate the request
  */
 export declare function beforeSubscribe<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: TriggerRequest<T>) => Promise<void> | undefined,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: TriggerRequest<T>) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: TriggerRequest<T>) => any)
 ): void;
 
@@ -567,8 +579,8 @@ export declare function beforeSubscribe<T extends ParseObject = ParseObject>(
  * @param validator An optional function to validate the request
  */
 export declare function afterLiveQueryEvent<T extends ParseObject = ParseObject>(
-  className: string | (new () => T),
-  handler: (request: LiveQueryEventTrigger<T>) => Promise<void> | undefined,
+  className: string | ParseObjectConstructor<T>,
+  handler: (request: LiveQueryEventTrigger<T>) => void | Promise<void> | undefined,
   validator?: ValidatorObject | ((request: LiveQueryEventTrigger<T>) => any)
 ): void;