Skip to content

react-native 0.43.3 compatibility #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjdp opened this issue Apr 12, 2017 · 10 comments
Closed

react-native 0.43.3 compatibility #428

jjdp opened this issue Apr 12, 2017 · 10 comments

Comments

@jjdp
Copy link

jjdp commented Apr 12, 2017

in version 0.43.3, they renamed the react-native.js to react-native-implementation.js in react-native/Libraries/react-native/

i do not know how to fix this dynamically, without breaking to support < RN 0.43.3

@maxim-kolesnikov
Copy link

I join, I encountered an error while updating:

error: bundling: UnableToResolveError: Unable to resolve module react-native/Libraries/react-native/react-native.jsfromreact-native-project/node_modules/parse/lib/react-native/StorageController.react-native.js: Module does not exist in the module map or in these directories: react-native-project/node_modules/react-native/Libraries/react-native

Could you tell us, do will support for this version? :(

@jjdp
Copy link
Author

jjdp commented Apr 14, 2017

change the import in the meantime. package needs a version bump say to determine what RN to support

@maxim-kolesnikov
Copy link

maxim-kolesnikov commented Apr 19, 2017

@jjdp
I with my team did support Parse-SDK-JS for RN v0.43:
https://github.com/allmaxgit/Parse-SDK-JS

You can try this:

"dependencies": {
  ...
  "react": "16.0.0-alpha.6",
  "react-native": "^0.43.2",
  "parse": "git+https://github.com/allmaxgit/Parse-SDK-JS.git",
  ...
}

watchman watch-del-all
rm -rf node_modules/ && npm i
npm start --reset-cache

@thiagoghisi
Copy link

@mxklsn please create a PR with that change. I would love to see it in the next parse release.

@mmazzarolo
Copy link

mmazzarolo commented Apr 27, 2017

@mxklsn thank you

@thiagoghisi yep, would be nice... I guess it would break the compatibility with the previous versions of React-Native though.

@jamlfy
Copy link

jamlfy commented Apr 29, 2017

Is the same #418

@adnbsr
Copy link

adnbsr commented May 19, 2017

@mxklsn Thanks for your contribution. Could you also check #435 which Throws error just for Android ?

@peterpme
Copy link

👋 anyway I can help push this along?

@felipemartim
Copy link

This seems to be fixed in 1.10.0.

@nesc58
Copy link

nesc58 commented Jul 21, 2017

Yes. Fixed with 1.10.0.

@jjdp jjdp closed this as completed Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants