-
-
Notifications
You must be signed in to change notification settings - Fork 596
Typescript definitions @types/parse need to be kept up to date #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👍 |
This was tried discussed before in a PR #388 As I understand it since this isn't a typescript repo we can't push autogenerated files to @types/parse An alternative would be to autogenerate a file with dts-gen and submit types on release Before that can happen two issues exists
I don't know why this happens as serverURL isn't readonly in the @type/parse but can be fix with the following workaround.
The second issue is that prototypes would be generated. There is a PR opened to address this microsoft/dts-gen#115 Manual pulls are required for now, I can do those for the time being. @agoldis @flovilmart @acinader @TimNZ Thoughts? |
Good idea! I am not sure about the quality of dts-gen output though, it might be worse than we currently have. Additional aspect is version upgrades - this requires some manipulation to the files structure of typedefs package, those are not frequent though and prob can be handled manually. @dplewis we can try to run |
I tried it and it works if you erase the prototype definitions (PR is waiting for approval). The readonly serverURL error still existed tho. |
@dplewis sorry I didn't have chance to explore this option. Any chance you can publish / gist the output you've got? |
Wheres the gist parse.d.ts To generate parse globally |
Thanks, @dplewis. To summarize, IMO:
What do you think about some hybrid process that wouldn't touch whatever is already there, but create a PR / notify about additions and / or detected changes? |
I submitted a pull to add Parse.liveQueryServerUrl to DefinitelyTyped repo, but it would be nice if that was part of the deployment workflow
The text was updated successfully, but these errors were encountered: