Allow any Blob to be uploaded #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 54 54
Lines 4933 4933
Branches 1097 1097
=======================================
Hits 4542 4542
Misses 391 391
Continue to review full report at Codecov.
|
`File` is a subclass of `Blob` and thus this will still accept any `File` as before. The benefit of also allowing `Blob` is that those are user-creatable, and you can get them from a `Canvas` if you are e.g. resizing images in the browser before uploading them.
|
Thanks for the quick merge 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fileis a subclass ofBloband thus this will still accept anyFileas before.The benefit of also allowing
Blobis that those are user-creatable, and you can get them from aCanvasif you are e.g. resizing images in the browser before uploading them.