Skip to content

Use buttons instead of javascript: links #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
damianstasik opened this issue Dec 2, 2021 · 2 comments · Fixed by #1940
Closed
4 tasks done

Use buttons instead of javascript: links #1941

damianstasik opened this issue Dec 2, 2021 · 2 comments · Fixed by #1940
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature

Comments

@damianstasik
Copy link
Contributor

New Issue Checklist

Issue Description

We are now getting warning messages about usage of deprecated javascript: URLs:

Warning: A future version of React will block javascript: URLs as a security precaution. Use event handlers instead if you can. If you need to generate unsafe HTML try using dangerouslySetInnerHTML instead. React was passed "javascript:;".

Steps to reproduce

Navigate between random pages and you will see this warning. The solution is to replace all of those links with proper buttons which would make the codebase one step closer to the modern React version.

Actual Outcome

Warning

Expected Outcome

No warning, no javascript: links in the code, no anchors in places where buttons should be used.

Environment

All

Dashboard

  • Parse Dashboard version: n/a
  • Browser (Safari, Chrome, Firefox, Edge, etc.): n/a
  • Browser version: n/a

Server

  • Parse Server version: n/a
  • Operating system: n/a
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): n/a

Database

  • System (MongoDB or Postgres): n/a
  • Database version: n/a
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): n/a

Logs

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added type:feature New feature or improvement of existing feature severity:low type:bug Impaired feature or lacking behavior that is likely assumed bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) and removed type:feature New feature or improvement of existing feature type:bug Impaired feature or lacking behavior that is likely assumed severity:low labels Dec 6, 2021
@mtrezza mtrezza linked a pull request Dec 6, 2021 that will close this issue
3 tasks
@mtrezza
Copy link
Member

mtrezza commented Dec 6, 2021

Closing via #1940

@mtrezza mtrezza closed this as completed Dec 6, 2021
@mtrezza mtrezza mentioned this issue Dec 12, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants