feat: Add option to reload all or only selected rows after invoking script

[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Feature

Add option "Script > Reload all rows after run" to reload the whole table or only selected rows after invoking a script. This prevents unnecessarily loading the whole data table and all related info panel data when only some rows may have changed.

If "Reload all rows after run" is disabled, the data table is not re-fetched, meaning any rows that after script invocation would not match the applied filter would still appear in the table. To update the table, the "Refresh" button needs to be clicked.

Summary by CodeRabbit

• New Features
  • Added a Script menu toggle to control data refresh behavior after script execution. Users can now choose between full table reload or selective refresh of only the affected objects for improved performance. Setting is automatically saved.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a persisted feature flag reloadDataTableAfterScript to choose between full table reload or selective object-level refresh after running scripts; threads two new refresh callbacks through components and updates ScriptUtils.executeScript to accept an optional onRefreshObjects callback.

Changes

Cohort / File(s)	Summary
Script execution & cell src/lib/ScriptUtils.js, src/components/BrowserCell/BrowserCell.react.js	executeScript signature extended to accept onRefreshObjects; BrowserCell conditionally supplies onRefresh vs onRefreshObjects based on reloadDataTableAfterScript.
Data browser core src/dashboard/Data/Browser/Browser.react.js, src/dashboard/Data/Browser/DataBrowser.react.js	Adds refreshObjects / handleRefreshObjects and toggleReloadDataTableAfterScript; implements selective object refresh flow with _skipPanelClear to suppress panel clearing during targeted refreshes; wires new methods and state.
Prop threading & UI toggle src/dashboard/Data/Browser/BrowserTable.react.js, src/dashboard/Data/Browser/BrowserToolbar.react.js, src/components/BrowserRow/BrowserRow.react.js	Threads onRefreshObjects and reloadDataTableAfterScript through table/row components; BrowserToolbar adds menu item and toggle for the flag.
Menu cleanup src/components/BrowserMenu/BrowserMenu.react.js	Removed setCurrent(null) calls from submenu mouse-enter and top-level entry click handlers.

Sequence Diagram

sequenceDiagram
    participant User
    participant BrowserCell as BrowserCell
    participant ScriptUtils as ScriptUtils
    participant Browser as Browser
    participant DataBrowser as DataBrowser

    User->>BrowserCell: trigger Execute script
    BrowserCell->>ScriptUtils: executeScript(script, className, objectId, showNote, onRefresh, onRefreshObjects)
    alt reloadDataTableAfterScript == true
        ScriptUtils->>Browser: onRefresh()
        Browser->>DataBrowser: full data table refresh
    else reloadDataTableAfterScript == false
        ScriptUtils->>Browser: onRefreshObjects([objectId])
        Browser->>DataBrowser: handleRefreshObjects(objectIds)
        DataBrowser->>DataBrowser: clear per-object cache\nset _skipPanelClear = true\nrefetch affected panels/objects
    end

Loading

Estimated Code Review Effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly Related PRs

• fix: Info panel not refreshing on script execution #3040: Modifies DataBrowser panel-clearing behavior; conceptually related to _skipPanelClear handling in this change.
• feat: Execute scripts via right-click on info panel header column #3068: Extends executeScript callback handling and BrowserCell integration, directly connected to the updated executeScript signature.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description provides a clear feature explanation but does not follow the repository template structure, missing explicit 'Issue' and 'Approach' sections, and lacks a 'Tasks' checklist.	Restructure the description to match the template by adding explicit 'Issue', 'Approach', and 'Tasks' sections, or clarify why the template sections are not applicable.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main feature: adding an option to control whether the data table reloads all rows or only selected rows after script execution.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@src/dashboard/Data/Browser/DataBrowser.react.js`:
- Around line 466-479: The _skipPanelClear flag is left true if
this.props.onRefreshObjects(objectIds) rejects; update handleRefreshObjects to
ensure the flag is always consumed by wrapping the asynchronous call in a
try/finally: set this._skipPanelClear = true before calling
this.props.onRefreshObjects, await the call inside try, and then in finally set
this._skipPanelClear = false so any rejection does not leave the flag set;
reference the handleRefreshObjects method and the this._skipPanelClear field
when making this change.
- Around line 675-713: handleRefreshObjects currently sets this._skipPanelClear
before awaiting this.props.onRefreshObjects and never resets it if the promise
rejects, and it doesn't guard against onRefreshObjects being undefined; update
handleRefreshObjects to check that this.props.onRefreshObjects is a function
before calling it, and wrap the await call in a try/finally so that
this._skipPanelClear is always cleared in the finally block (optionally log the
error in the catch). Reference: method handleRefreshObjects, the field
_skipPanelClear, and this.props.onRefreshObjects.

🧹 Nitpick comments (2)

src/dashboard/Data/Browser/Browser.react.js (1)

188-188: localStorage key is not scoped to the app.

The reloadDataTableAfterScript key in localStorage is global across all Parse apps managed by this dashboard instance. This is consistent with how browserLimit is stored (also a global key), so this appears intentional. Just noting that switching between apps will share this preference.

src/dashboard/Data/Browser/DataBrowser.react.js (1)

2941-2956: Consider extracting the duplicated executeScript callback logic.

The conditional onRefresh/onRefreshObjects pattern at lines 2951-2952 is identical to lines 1340-1341. A small helper (e.g., getScriptRefreshCallbacks()) would keep the two call sites in sync and reduce the chance of future drift.

Example helper

+  getScriptRefreshCallbacks() {
+    return {
+      onRefresh: this.props.reloadDataTableAfterScript ? this.props.onRefresh : null,
+      onRefreshObjects: this.props.reloadDataTableAfterScript ? null : this.handleRefreshObjects,
+    };
+  }

Then at each call site:

const { onRefresh, onRefreshObjects } = this.getScriptRefreshCallbacks();
executeScript(script, className, objectId, this.props.showNote, onRefresh, onRefreshObjects);

[parseplatformorg]

🎉 This change has been released in version 8.5.0-alpha.6

[parseplatformorg]

🎉 This change has been released in version 8.5.0