fix: Column resizing mouse cursor in data browser not visible in Safari browser#3246
Conversation
|
🚀 Thanks for opening this pull request! |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughThis PR refactors the column drag handle implementation in the data browser, shifting handle positioning and styling from JavaScript-computed inline styles and props to CSS-based absolute positioning with conditional styling classes. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.js (1)
143-148: Thekeyprop on DragHandle is redundant.The
key={'handle' + i}is unnecessary since DragHandle is a single element inside the parent div which already has a unique key (key={'header' + i}). Keys are used for React reconciliation of sibling elements in lists, not for single child elements.♻️ Suggested fix
<DragHandle - key={'handle' + i} className={handleClassName} onDrag={onResize.bind(null, i)} onClick={e => e.stopPropagation()} />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.js` around lines 143 - 148, Remove the redundant key prop on the DragHandle element inside DataBrowserHeaderBar: delete the key={'handle' + i} attribute from the DragHandle JSX (the parent div already uses key={'header' + i}), leaving DragHandle with className={handleClassName}, onDrag={onResize.bind(null, i)} and onClick handler unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.js`:
- Around line 143-148: Remove the redundant key prop on the DragHandle element
inside DataBrowserHeaderBar: delete the key={'handle' + i} attribute from the
DragHandle JSX (the parent div already uses key={'header' + i}), leaving
DragHandle with className={handleClassName}, onDrag={onResize.bind(null, i)} and
onClick handler unchanged.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/components/DataBrowserHeader/DataBrowserHeader.scsssrc/components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.jssrc/components/DataBrowserHeaderBar/DataBrowserHeaderBar.scsssrc/dashboard/Data/Browser/BrowserTable.react.js
💤 Files with no reviewable changes (2)
- src/components/DataBrowserHeader/DataBrowserHeader.scss
- src/dashboard/Data/Browser/BrowserTable.react.js
# [9.1.0-alpha.6](9.1.0-alpha.5...9.1.0-alpha.6) (2026-03-02) ### Bug Fixes * Column resizing mouse cursor in data browser not visible in Safari browser ([#3246](#3246)) ([e6fb4d7](e6fb4d7))
|
🎉 This change has been released in version 9.1.0-alpha.6 |
Pull Request
Issue
Column resizing mouse cursor in data browser not visible in Safari browser
Tasks
Summary by CodeRabbit
Style
Refactor