Skip to content

Add "iconUrl" for remote icon files #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jashsayani opened this issue Sep 7, 2016 · 3 comments
Closed

Add "iconUrl" for remote icon files #526

jashsayani opened this issue Sep 7, 2016 · 3 comments
Labels
state:wont-fix Won’t be fixed with a clearly stated reason

Comments

@jashsayani
Copy link

I see that the dashboard allows for iconsFolder and iconName for each app. This is a decent way of pointing to an icons directory and defining icons for each app, but I would like to just point to an iconUrl that is a static file hosted somewhere (essentially linking to AppStore or Google Play CDN of the app icon asset). This way, when the icon is updated for the app, the dashboard would show the new icon (or break if CDN link changes on update), and I can update the link with the new icon.

@natanrolnik
Copy link
Contributor

@jashsayani Yep, that's an interesting improvement to the currently existing feature. I implemented, with the help of Drew Gross, the support only for icons in the iconsFolder. PRs are welcome.

@markmssd
Copy link

That would be very interesting indeed!

@stale
Copy link

stale bot commented Jan 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state:wont-fix Won’t be fixed with a clearly stated reason label Jan 11, 2019
@stale stale bot closed this as completed Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:wont-fix Won’t be fixed with a clearly stated reason
Projects
None yet
Development

No branches or pull requests

3 participants