Skip to content

Certificate Pinning #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kingmatusevich opened this issue Jan 29, 2016 · 5 comments · Fixed by #513
Closed

Certificate Pinning #218

kingmatusevich opened this issue Jan 29, 2016 · 5 comments · Fixed by #513

Comments

@kingmatusevich
Copy link

The SDKs should be compatible with pinned certificates for connecting to the Parse Servers, allowing for faster, safer deployment, particularly in small or internal deployments.

@davidtavarez
Copy link

@montymxb @kingmatusevich is this issue closed?

@montymxb
Copy link
Contributor

@davidtavarez Nope, it is still open and still something we are happy to implement in the future; but no work has started on this yet.

@dplewis
Copy link
Member

dplewis commented Jul 19, 2019

Doesn't ParseClient::setCAFile already kinda does this? I can add a valid test for this.

What other types of SSL/TLS check would be needed? (That would support both cURL and stream_context).

@dplewis
Copy link
Member

dplewis commented May 11, 2023

This can be achieved by creating your own HTTP client and pass in your SSL/TLS options

ParseClient::setHttpClient(new CustomHTTPClient());

https://github.com/parse-community/parse-php-sdk#http-clients

We could add ParseClient::setOptions() to support certificate pinning out of the box for both cURL and stream clients. This would also support any of the many other features for cURL and stream context.

@dplewis
Copy link
Member

dplewis commented May 13, 2023

For those interested I added an example for public key pinning, cert fingerprint checking, peer verification in PHP and JavaScript (not really a thing in javascript but useful) using self signed certs #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants