feat: add AWS SES payload adapter #65

woutercouvaras · 2022-09-13T08:53:09Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Add support for an AWS SES Adapter

Related issue: #64

Approach

Very simply, I've just added a transformer to match the required SES payload for the v3 SDK.
I've also updated two parameter names in the documentation as they did not match the original Parse payload I was receiving. I've also added an example of how to use it in the docs.

This is my first ever open source PR, so happy for any guidance :)

TODOs before merging

Add test cases
Add entry to changelog
Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant · 2022-09-13T08:53:14Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov · 2022-09-13T09:40:55Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (82f8d43) compared to base (4db06d2).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 82f8d43 differs from pull request most recent head 360c773. Consider uploading reports for the commit 360c773 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##             alpha       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          515       546   +31     
  Branches        41        47    +6     
=========================================
+ Hits           515       546   +31

Impacted Files	Coverage Δ
spec/ApiMailAdapter.spec.js	`100.00% <100.00%> (ø)`
src/ApiPayloadConverter.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

woutercouvaras · 2022-09-13T10:11:39Z

I'm embarassed to say that I didn't see the tests before :) I'll take a look at them and try to fix the coverage issue, as well as these other issues.

parse-github-assistant · 2022-09-13T10:12:48Z

I will reformat the title to use the proper commit message syntax.

woutercouvaras · 2022-09-13T10:54:36Z

@mtrezza let me know if you need me to tackle anything else.

README.md

spec/ApiMailAdapter.spec.js

src/ApiPayloadConverter.js

woutercouvaras · 2022-09-13T11:54:41Z

I've pushed the suggested changes. Not sure I should be the one to resolve those, sorry. I should have checked with you first.

README.md

src/ApiPayloadConverter.js

README.md

src/ApiPayloadConverter.js

README.md

mtrezza

Looks good! Waiting for CI to pass, then let's merge!

src/ApiPayloadConverter.js

…-api-mail-adapter into ses-provider

mtrezza · 2022-09-15T09:10:03Z

I refactored the payload converter to remove some code duplication.

The test pass, so it should be fine, but could you still just check whether this works?

woutercouvaras · 2022-09-15T09:41:56Z

Yes, all still works! 💪

mtrezza

Looks good! Thanks for adding the SES converter!

# [2.1.0-alpha.9](2.1.0-alpha.8...2.1.0-alpha.9) (2022-09-15) ### Features * add AWS SES payload adapter ([#65](#65)) ([4ecc4c9](4ecc4c9))

github-actions · 2022-09-15T09:51:11Z

🎉 This pull request has been released in version 2.1.0-alpha.9

woutercouvaras · 2022-09-15T09:58:02Z

Thanks for your patience! I've learned a lot through the process. My next contribution will be of a higher quality:)

woutercouvaras · 2022-09-15T10:56:52Z

@mtrezza I see npm has been updated with the new release number, yet the ses provider is not present. Am I missing something? Please forgive me if I've got my wires crossed!

mtrezza · 2022-09-15T14:07:54Z

yet the ses provider is not present

What do you mean by "not present"?
If you look at the source code in node_modules, it should be there. Maybe you are looking at a different version? Try to delete the node_modules and package-lock.json file in your app and run npm i. Also make sure you have added the correct adapter version 2.1.0-alpha.9 in package.json.

woutercouvaras · 2022-09-16T05:53:03Z

Hi, I've deleted the lock file, node_modules and ensured that v 2.1.0 is installed, but I still see the previous version - i.e. without the ses converter. When I look on npm, the readme <https://www.npmjs.com/package/parse-server-api-mail-adapter> is also the previous version. i.e. without the ses converter.

…

On Thu, Sep 15, 2022 at 4:08 PM Manuel ***@***.***> wrote: yet the ses provider is not present What do you mean by "not present"? If you look at the source code in node_modules, it should be there. Maybe you are looking at a different version? Try to delete the node_modules and package-lock.json file in your app and run npm i. Also make sure you have added the correct adapter version in package.json. — Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEIB74HWEZGW6GLYVJFF6DV6MUUJANCNFSM6AAAAAAQLGZ3LM> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

-- ---------------------------------------------- *Wouter* Couvaras +27 (0) 79 878 6294 *www.hootoriginals.com* <http://www.hootoriginals.com> ---------------------------------------------- Disclaimer: If you are not the addressee indicated in this message (or responsible for delivery of the message to such person), you may not copy or deliver this message to anyone - you should destroy this message and kindly notify the sender by reply email. Content in this message that do not relate to the official business of my employer, being Hoot Originals, shall be understood as neither given nor endorsed or authorised by it. Although all reasonable care is taken to transmit this message free of any damaging code, Hoot Originals and the sender do not make any warranties in this regard whatsoever and cannot be held liable for any loss or damages incurred by the recipient. *© Hoot Originals 2019. *All rights reserved.

mtrezza · 2022-09-16T08:27:14Z

You need to look at the right version:

https://www.npmjs.com/package/parse-server-api-mail-adapter/v/2.1.0-alpha.9#providers

The item is missing in the index (I'll correct that), but if you scroll to the text it's there.

woutercouvaras · 2022-09-16T08:56:20Z

Gotcha, thanks!

…

On Fri, Sep 16, 2022 at 10:27 AM Manuel ***@***.***> wrote: You need to look at the right version: https://www.npmjs.com/package/parse-server-api-mail-adapter/v/2.1.0-alpha.9#providers The item is missing in the index, but if you scroll to the text it's there. — Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEIB77LOBTOPX7PWXGNDH3V6QVO3ANCNFSM6AAAAAAQLGZ3LM> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

-- ---------------------------------------------- *Wouter* Couvaras +27 (0) 79 878 6294 *www.hootoriginals.com* <http://www.hootoriginals.com> ---------------------------------------------- Disclaimer: If you are not the addressee indicated in this message (or responsible for delivery of the message to such person), you may not copy or deliver this message to anyone - you should destroy this message and kindly notify the sender by reply email. Content in this message that do not relate to the official business of my employer, being Hoot Originals, shall be understood as neither given nor endorsed or authorised by it. Although all reasonable care is taken to transmit this message free of any damaging code, Hoot Originals and the sender do not make any warranties in this regard whatsoever and cannot be held liable for any loss or damages incurred by the recipient. *© Hoot Originals 2019. *All rights reserved.

# [2.1.0-beta.2](2.1.0-beta.1...2.1.0-beta.2) (2023-01-24) ### Bug Fixes * bump nanoid from 3.1.29 to 3.2.0 ([#56](#56)) ([76a374b](76a374b)) * bump trim-off-newlines from 1.0.1 to 1.0.3 ([#57](#57)) ([794cfb6](794cfb6)) * security upgrade minimist from 1.2.5 to 1.2.6 ([#59](#59)) ([1a5253f](1a5253f)) * security upgrade node-fetch from 2.6.1 to 2.6.7 ([#60](#60)) ([576d336](576d336)) * security upgrade semver-regex from 3.1.3 to 3.1.4 ([#62](#62)) ([4db06d2](4db06d2)) ### Features * add AWS SES payload adapter ([#65](#65)) ([4ecc4c9](4ecc4c9))

github-actions · 2023-01-24T22:23:57Z

🎉 This pull request has been released in version 2.1.0-beta.2

# [2.2.0](2.1.0...2.2.0) (2023-01-24) ### Bug Fixes * bump nanoid from 3.1.29 to 3.2.0 ([#56](#56)) ([76a374b](76a374b)) * bump trim-off-newlines from 1.0.1 to 1.0.3 ([#57](#57)) ([794cfb6](794cfb6)) * security upgrade minimist from 1.2.5 to 1.2.6 ([#59](#59)) ([1a5253f](1a5253f)) * security upgrade node-fetch from 2.6.1 to 2.6.7 ([#60](#60)) ([576d336](576d336)) * security upgrade semver-regex from 3.1.3 to 3.1.4 ([#62](#62)) ([4db06d2](4db06d2)) ### Features * add AWS SES payload adapter ([#65](#65)) ([4ecc4c9](4ecc4c9))

github-actions · 2023-01-24T23:19:36Z

🎉 This pull request has been released in version 2.2.0

woutercouvaras added 2 commits September 13, 2022 10:04

feat: A SES provider

6c017b6

fix: updated SES example

8b85e2d

woutercouvaras mentioned this pull request Sep 13, 2022

SES Provider #64

Closed

3 tasks

woutercouvaras changed the title ~~Ses provider~~ feat: A SES provider for v3 SDK Sep 13, 2022

parse-github-assistant bot changed the title ~~feat: A SES provider for v3 SDK~~ feat: a SES provider for v3 SDK Sep 13, 2022

woutercouvaras added 2 commits September 13, 2022 12:19

fix: linting issue addressed

dad785f

fix: reset param names to match sendMail metchod

a9c95f2

mtrezza linked an issue Sep 13, 2022 that may be closed by this pull request

SES Provider #64

Closed

3 tasks

mtrezza changed the title ~~feat: a SES provider for v3 SDK~~ feat: add AWS SES payload adapter Sep 13, 2022

woutercouvaras added 2 commits September 13, 2022 12:48

feat: test for ses converter

f8bcc1d

fix: updates to ses converter as caught by tests

f622669

mtrezza requested changes Sep 13, 2022

View reviewed changes

woutercouvaras added 2 commits September 13, 2022 13:51

fix: requested updates

792f685

fix: requested updates

cdea2d4