Skip to content

Commit 33e3993

Browse files
authored
Fixes issue where info logs would appear in error logs (#2647)
* Reproduction of #2639 * Make sure the error level options is enforced
1 parent 5676a6f commit 33e3993

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

spec/WinstonLoggerAdapter.spec.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,19 @@ describe('info logs', () => {
1616
}, (results) => {
1717
if (results.length == 0) {
1818
fail('The adapter should return non-empty results');
19-
done();
2019
} else {
2120
expect(results[0].message).toEqual('testing info logs');
22-
done();
2321
}
22+
// Check the error log
23+
// Regression #2639
24+
winstonLoggerAdapter.query({
25+
from: new Date(Date.now() - 500),
26+
size: 100,
27+
level: 'error'
28+
}, (results) => {
29+
expect(results.length).toEqual(0);
30+
done();
31+
});
2432
});
2533
});
2634
});

src/Adapters/Logger/WinstonLogger.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,15 @@ function updateTransports(options) {
1818
delete transports['parse-server-error'];
1919
} else if (!_.isUndefined(options.dirname)) {
2020
transports['parse-server'] = new (DailyRotateFile)(
21-
Object.assign({
21+
Object.assign({}, {
2222
filename: 'parse-server.info',
2323
name: 'parse-server',
2424
}, options));
2525
transports['parse-server-error'] = new (DailyRotateFile)(
26-
Object.assign({
26+
Object.assign({}, {
2727
filename: 'parse-server.err',
2828
name: 'parse-server-error',
29-
level: 'error'
30-
}, options));
29+
}, options, { level: 'error'}));
3130
}
3231

3332
transports.console = new (winston.transports.Console)(

0 commit comments

Comments
 (0)