perf: reduce database operations when using the constant parameter in Cloud Function validation (#7892)

dblythy · mtrezza · commit d43e2dadcbf0 · 2022-05-01T02:40:46.000+02:00
diff --git a/src/triggers.js b/src/triggers.js
@@ -738,7 +738,7 @@ async function builtInTriggerValidator(options, request, auth) {
         }
         if (opt.constant && request.object) {
           if (request.original) {
-            request.object.set(key, request.original.get(key));
+            request.object.revert(key);
           } else if (opt.default != null) {
             request.object.set(key, opt.default);
           }

Original file line number	Diff line number	Diff line change
`@@ -738,7 +738,7 @@ async function builtInTriggerValidator(options, request, auth) {`
`738`	`738`	`}`
`739`	`739`	`if (opt.constant && request.object) {`
`740`	`740`	`if (request.original) {`
`741`		`- request.object.set(key, request.original.get(key));`
	`741`	`+ request.object.revert(key);`
`742`	`742`	`} else if (opt.default != null) {`
`743`	`743`	`request.object.set(key, opt.default);`
`744`	`744`	`}`