Skip to content

Missing mount point in "invalid_verification_link.html" #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gitzoz opened this issue May 23, 2017 · 10 comments
Closed

Missing mount point in "invalid_verification_link.html" #3857

Gitzoz opened this issue May 23, 2017 · 10 comments
Labels
state:wont-fix Won’t be fixed with a clearly stated reason type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@Gitzoz
Copy link

Gitzoz commented May 23, 2017

Hello everyone,
on the invalid_verification_link page the button to resend verification email
has a wrong url. It gets the appId from the given url but not the mount point.

It has: https://xxxx/app/{appId}/resend_verification_email
it should have: https://xxxx/{mountpoint}/app/{appId}/resend_verification_email

In my ParseServer config I have set the publicServerURL correct. Everything else works fine.

ParseServer Version: 2.4.1
Procedure: Open a invalid verification link and click on the button "Resend Link"

Hope that helps

Best regards
Gitzoz

@funkenstrahlen
Copy link
Contributor

I am running the current parse server version 2.5.3. I see the exact same problem.

@funkenstrahlen
Copy link
Contributor

This script creates the resend verification link. It obviously ignores mount point.

  <script type="text/javascript">
    function getUrlParameter(name) {
      name = name.replace(/[\[]/, '\\[').replace(/[\]]/, '\\]');
      var regex = new RegExp('[\\?&]' + name + '=([^&#]*)');
      var results = regex.exec(location.search);
      return results === null ? '' : decodeURIComponent(results[1].replace(/\+/g, ' '));
    };  
    window.onload = addDataToForm;
    function addDataToForm() {
      var username = getUrlParameter("username");
      document.getElementById("usernameField").value = username;
      var appId = getUrlParameter("appId");
      document.getElementById("resendForm").action = '/apps/' + appId + '/resend_verification_email'
    }
  </script>

@funkenstrahlen
Copy link
Contributor

funkenstrahlen commented Jul 5, 2017

@flovilmart Is there any way to make this html response more dynamic so we can pass parameters into this file like appId and serverUrl?

I think the current approach to work with regex on the url is not very reliable and ready for future changes. I would like to work on this and provide a PR in case you can give me a tip on how to pass in parameters. However I do not want to make this JS regex approach even more complicated.

@flovilmart
Copy link
Contributor

Yes you’re right, it’s bound to be problematic. Do you wanna take a dent at it? I would be ok with simple templating for rendering those pages.

@stale
Copy link

stale bot commented Sep 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 18, 2018
@funkenstrahlen
Copy link
Contributor

This is still an issue.

@stale stale bot removed the wontfix label Sep 18, 2018
@flovilmart
Copy link
Contributor

@funkenstrahlen are you willing to make a PR for it? Obviously this should be fixed. What bugs me is that all other pages are fine right?

@stale
Copy link

stale bot commented Nov 2, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 2, 2018
@stale stale bot closed this as completed Nov 9, 2018
@tommylp
Copy link

tommylp commented Aug 30, 2021

This is still an issue in parse-server 4.5.0. The url do not reflect the pages endpoint. Related Issue:
#7235
#7236

@mtrezza
Copy link
Member

mtrezza commented Oct 15, 2021

Closed as won't fix, see #7533 (comment) why.

@mtrezza mtrezza added type:bug Impaired feature or lacking behavior that is likely assumed severity:low state:wont-fix Won’t be fixed with a clearly stated reason labels Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:wont-fix Won’t be fixed with a clearly stated reason type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

5 participants