-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Missing mount point in "invalid_verification_link.html" #3857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am running the current parse server version |
This script creates the resend verification link. It obviously ignores mount point. <script type="text/javascript">
function getUrlParameter(name) {
name = name.replace(/[\[]/, '\\[').replace(/[\]]/, '\\]');
var regex = new RegExp('[\\?&]' + name + '=([^&#]*)');
var results = regex.exec(location.search);
return results === null ? '' : decodeURIComponent(results[1].replace(/\+/g, ' '));
};
window.onload = addDataToForm;
function addDataToForm() {
var username = getUrlParameter("username");
document.getElementById("usernameField").value = username;
var appId = getUrlParameter("appId");
document.getElementById("resendForm").action = '/apps/' + appId + '/resend_verification_email'
}
</script> |
@flovilmart Is there any way to make this html response more dynamic so we can pass parameters into this file like I think the current approach to work with regex on the url is not very reliable and ready for future changes. I would like to work on this and provide a PR in case you can give me a tip on how to pass in parameters. However I do not want to make this JS regex approach even more complicated. |
Yes you’re right, it’s bound to be problematic. Do you wanna take a dent at it? I would be ok with simple templating for rendering those pages. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is still an issue. |
@funkenstrahlen are you willing to make a PR for it? Obviously this should be fixed. What bugs me is that all other pages are fine right? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closed as won't fix, see #7533 (comment) why. |
Hello everyone,
on the invalid_verification_link page the button to resend verification email
has a wrong url. It gets the appId from the given url but not the mount point.
It has: https://xxxx/app/{appId}/resend_verification_email
it should have: https://xxxx/{mountpoint}/app/{appId}/resend_verification_email
In my ParseServer config I have set the publicServerURL correct. Everything else works fine.
ParseServer Version: 2.4.1
Procedure: Open a invalid verification link and click on the button "Resend Link"
Hope that helps
Best regards
Gitzoz
The text was updated successfully, but these errors were encountered: