Skip to content

GDPR compliance #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtrezza opened this issue Feb 19, 2019 · 12 comments
Open

GDPR compliance #5378

mtrezza opened this issue Feb 19, 2019 · 12 comments
Labels
bounty:$500 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Feb 19, 2019

TL;DR: This feature request describes data access and modification logging which is a legal requirement that presumably 99% of app providers using Parse Server / Parse Dashboard currently fail to meet.


Is your feature request related to a problem? Please describe.
Parse Server offers data access and manipulation via its Parse Dashboard. For the dashboard to be usable in a business (or even "hobby developer") environment, Parse Server needs to comply with GDPR if it handles data of "EU users"*.

The dashboard is the main (and only?) tool of Parse Server for quick and easy manual data view and manipulation. It would be beneficial for many users if the dashboard (in connection with parse server) complied with GDPR.

Describe the solution you'd like
A mechanism that logs:

  • User login
  • Data view
  • Data manipulation (entry / modification)
  • Schema manipulation
  • ACL manipulation
  • Push sending

The easiest way would probably be to add a logging mechanism to the Parse Dashboard alone, without any modification of Parse Server, if that's possible. It should store the logs in a separate file, so these logs files can be easily dealt with according to archiving requirement of GDPR (audit-proof, etc).

Describe alternatives you've considered
Not making the dashboard GRPD compliant would render it legally unusable for aforementioned data.
Alternatives:

  • Data manipulation directly in the DB; that shifts the GDPR compliance requirement to the DB interface.
  • Create a separate app with user management and logging, essentially replicating functions of the parse dashboard.

Additional context

  • GDPR compliance requires the logging of data access and data modification (among many other things) for data of EU residents (regardless of citizenship) and EU citizens (regardless of residency). GDPR is enforceable since 25 May 2018.
@acinader
Copy link
Contributor

I assume that doing this at the data level (i.e. mongo logging) would not be adequate cause we don't have the user associated with the changes.

Adding to the dashboard seems reasonable to me. Would you be willing to open a pr to get it started?

@mtrezza
Copy link
Member Author

mtrezza commented Feb 24, 2019

Logging on DB level was just meant as alternative if someone decides to not use Parse Dashboard and wants to be GDPR compliant.

Without committing to a PR at this point, I would like to start a conceptual discussion about how / where to implement it. So we can estimate the effort and someone can pick it up.

Suggestion 1 - dashboard centric

  1. parse server is initialized with parameter for log file path; can be set as environment variable
  2. dashboard logs commands it sends to the server at a central point
  3. dashboard calls function in parse server to log command
  4. parse server writes log entry to a log file as set in the parse server

Suggestion 2 - server centric

We could leverage the client key and instruct parse server to log commands of selected clients. IIRC each parse client SDK has a client key property based on which the server could identify clients and determine whether to log the command.

var api = new ParseServer({
    log: {
        clients: [
            {
                key: "parseDashboard",
                logging: true
            },
            {
                key: "customAdminClient",
                logging: true
            }
        ]
    }
});
  • We can then log direct commands like a query.find(), but also calling a cloud function that executes multiple commands with useMasterKey where we would otherwise loose track of which client triggered the commands.
  • This way a custom developed admin app could that calls for example cloud functions could also be logged. So when a business has a moderation app and deletes a user account that could be logged.
  • Because the logging would all happen server side it would be consolidated for easier audit.

I prefer suggestion 2.

@mrmarcsmith
Copy link
Contributor

Even for apps that don’t require GDPR I think this is a awesome idea. I don’t have a ton of time to help with a PR but would love to weigh in on the conceptual. I would much rather see the “server centric” solution than the parse dashboard one aswell. “In theory” those with dashboard access could potentially retrieve the master key and cercumvent the dashboard logging all together. Where as, when it’s baked into parse server there isn’t any way around the logging.

@TomWFox TomWFox added the type:feature New feature or improvement of existing feature label May 5, 2019
@stale
Copy link

stale bot commented Jul 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 3, 2019
@mtrezza
Copy link
Member Author

mtrezza commented Jul 4, 2019

don't close, open issue

@stale stale bot removed the wontfix label Jul 4, 2019
@dplewis dplewis added type:question Support or code-level question up for grabs labels Jul 4, 2019
@stale
Copy link

stale bot commented Aug 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 18, 2019
@stale stale bot removed the wontfix label Aug 18, 2019
@mtrezza
Copy link
Member Author

mtrezza commented Aug 19, 2019

don't close, still relevant

@TomWFox
Copy link
Contributor

TomWFox commented Aug 19, 2019

It won’t be closed now I’ve added the ‘help wanted’ label 🙂

@mtrezza
Copy link
Member Author

mtrezza commented Mar 10, 2020

Stumbled across Parse Auditor, which addresses this issue. Not sure yet whether it is fully GDRP compliant.

https://github.com/Blackburn-Labs/parse-auditor

@mtrezza mtrezza removed help wanted type:question Support or code-level question labels Nov 1, 2020
@mtrezza
Copy link
Member Author

mtrezza commented Jan 13, 2021

@mtrezza mtrezza added the bounty:$100 Bounty applies for fixing this issue (Parse Bounty Program) label Oct 5, 2021
@dblythy
Copy link
Member

dblythy commented Apr 6, 2022

Is this in progress at all?

@mtrezza mtrezza added bounty:$500 Bounty applies for fixing this issue (Parse Bounty Program) and removed bounty:$100 Bounty applies for fixing this issue (Parse Bounty Program) labels Jan 31, 2023
@RahulLanjewar93
Copy link
Contributor

Stumbled across Parse Auditor, which addresses this issue. Not sure yet whether it is fully GDRP compliant.

https://github.com/Blackburn-Labs/parse-auditor

This package overwrites the triggers, which is not feasible. So I created another package that pretty much does the same.
It's not GDPR Compliant but if someone wants to use it here's the link
https://github.com/RahulLanjewar93/parse-audit-log

Suggestions are appreciated thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$500 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

7 participants