Skip to content

Add CI check for performance impact #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
mtrezza opened this issue Apr 9, 2021 · 5 comments
Open
3 tasks done

Add CI check for performance impact #7329

mtrezza opened this issue Apr 9, 2021 · 5 comments
Labels
type:meta Non-code issue

Comments

@mtrezza
Copy link
Member

mtrezza commented Apr 9, 2021

New Feature / Enhancement Checklist

Current Limitation

Currently, changes in Parse Server are not evaluated based on their Parse Server performance impact. This can lead to "hidden" degradation of Parse Server that won't be discovered for a long time. When a performance issue is discovered, it is usually hard to pin down the root cause in retrospect.

Feature / Enhancement Description

Add CI check that evaluates performance impact.

Example Use Case

n/a

Alternatives / Workarounds

Unknown

3rd Party References

Unknown

@mtrezza mtrezza added the type:meta Non-code issue label Apr 9, 2021
@mtrezza mtrezza changed the title Add CI check for performance change Add CI check for performance impact Apr 9, 2021
@mtrezza
Copy link
Member Author

mtrezza commented Apr 9, 2021

@dplewis any idea how to go about this?

Could we use https://github.com/parse-community/benchmark or rather a 3rd part tool?

@dplewis
Copy link
Member

dplewis commented Jun 4, 2021

@mtrezza I would recommend it since I built as a GitHub bot and we would have control over it or we could use some similar third party tool.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 4, 2021

Maybe a 3rd party tool would be better as it relieves us of maintaining it.

For example https://github.com/rhysd/github-action-benchmark

It seems this does actually exactly what we need, incl. visualization and PR bot alert.

@dplewis
Copy link
Member

dplewis commented Jun 4, 2021

I wish that was around 2 years ago lol. That is something we can look into.

Do Github Action VM's have the same specs every run? I assume so

@mtrezza
Copy link
Member Author

mtrezza commented Jun 4, 2021

Let's find out.

We could start with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:meta Non-code issue
Projects
None yet
Development

No branches or pull requests

2 participants