-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add CI check for performance impact #7329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@dplewis any idea how to go about this? Could we use https://github.com/parse-community/benchmark or rather a 3rd part tool? |
@mtrezza I would recommend it since I built as a GitHub bot and we would have control over it or we could use some similar third party tool. |
Maybe a 3rd party tool would be better as it relieves us of maintaining it. For example https://github.com/rhysd/github-action-benchmark It seems this does actually exactly what we need, incl. visualization and PR bot alert. |
I wish that was around 2 years ago lol. That is something we can look into. Do Github Action VM's have the same specs every run? I assume so |
Let's find out. We could start with:
|
New Feature / Enhancement Checklist
Current Limitation
Currently, changes in Parse Server are not evaluated based on their Parse Server performance impact. This can lead to "hidden" degradation of Parse Server that won't be discovered for a long time. When a performance issue is discovered, it is usually hard to pin down the root cause in retrospect.
Feature / Enhancement Description
Add CI check that evaluates performance impact.
Example Use Case
n/a
Alternatives / Workarounds
Unknown
3rd Party References
Unknown
The text was updated successfully, but these errors were encountered: