Skip to content

Upgrade Redis 3 to 4 #8276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
Tracked by #8225
mtrezza opened this issue Nov 2, 2022 · 9 comments · Fixed by #8293 or #8333
Closed
3 tasks done
Tracked by #8225

Upgrade Redis 3 to 4 #8276

mtrezza opened this issue Nov 2, 2022 · 9 comments · Fixed by #8293 or #8333
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Nov 2, 2022

New Feature / Enhancement Checklist

Current Limitation

Node Redis dependency should be upgraded form 3 to 4, which includes a breaking change, see migration guide.

Feature / Enhancement Description

Upgrade to Redis 4 with Parse Sever 6 release.

Example Use Case

n/a

Alternatives / Workarounds

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 2, 2022

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added type:feature New feature or improvement of existing feature block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Nov 2, 2022
@mtrezza mtrezza mentioned this issue Nov 2, 2022
31 tasks
@MobileVet
Copy link

@mtrezza Ironically we were just looking at this today as we look to migrate away from Heroku. We had trouble connecting to the Redis instance without TLS (it is on a private network) but it worked fine from outside the network using TLS.

We forced Parse Server to utilize the Node Redis driver 4.4.0 and everything worked just fine on Parse Server 5.2.7. I wonder if there is anything that is actually required to make the update for Parse 6?

@mtrezza
Copy link
Member Author

mtrezza commented Nov 2, 2022

Great that you already looked into that. I just fixed a conflict in the PR, so we can see whether the CI passes. If it passes, it still would be good if someone could take a look at the migration guide to see whether there is anything relevant for Parse Server. Not sure how good the Redis test coverage in Parse Server is.

For example:

The configuration object passed to createClient has changed significantly with this release. See the client configuration guide for details.

...and indeed, the CI in the PR fails with:

TypeError: Cannot read properties of undefined (reading 'createClient')

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 11, 2022
@parse-github-assistant
Copy link

The label state:released-alpha cannot be used in combination with state:breaking.

@parse-github-assistant parse-github-assistant bot removed the state:released-alpha Released as alpha version label Nov 11, 2022
@dblythy
Copy link
Member

dblythy commented Nov 23, 2022

Reopening as the Redis Live Query publisher was not updated

@dblythy dblythy reopened this Nov 23, 2022
@mtrezza mtrezza added the state:released-alpha Released as alpha version label Nov 23, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.12

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
4 participants