From f5a04a800930267cadf44a877b569ac1ce45c5c6 Mon Sep 17 00:00:00 2001 From: Antoine Cormouls Date: Fri, 18 Dec 2020 14:49:41 +0100 Subject: [PATCH 1/3] fix max listner warning --- src/Adapters/PubSub/EventEmitterPubSub.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Adapters/PubSub/EventEmitterPubSub.js b/src/Adapters/PubSub/EventEmitterPubSub.js index 1ecc006e0c..006c8ffc2e 100644 --- a/src/Adapters/PubSub/EventEmitterPubSub.js +++ b/src/Adapters/PubSub/EventEmitterPubSub.js @@ -46,6 +46,10 @@ function createPublisher(): any { } function createSubscriber(): any { + // createSubscriber is called once at live query server start + // to avoid max listeners warning, we should clean up the event emitter + // each time this function is called + if (emitter) emitter.removeAllListeners(); return new Subscriber(emitter); } From 39cbe0f8d6f4a9e71e663ac26735bd4643ed37a3 Mon Sep 17 00:00:00 2001 From: Antoine Cormouls Date: Fri, 18 Dec 2020 15:07:38 +0100 Subject: [PATCH 2/3] fix --- src/Adapters/PubSub/EventEmitterPubSub.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Adapters/PubSub/EventEmitterPubSub.js b/src/Adapters/PubSub/EventEmitterPubSub.js index 006c8ffc2e..277118a082 100644 --- a/src/Adapters/PubSub/EventEmitterPubSub.js +++ b/src/Adapters/PubSub/EventEmitterPubSub.js @@ -49,7 +49,7 @@ function createSubscriber(): any { // createSubscriber is called once at live query server start // to avoid max listeners warning, we should clean up the event emitter // each time this function is called - if (emitter) emitter.removeAllListeners(); + emitter.removeAllListeners(); return new Subscriber(emitter); } From b4709884def4211f627d66dddfcefb864224d6f6 Mon Sep 17 00:00:00 2001 From: Antoine Cormouls Date: Mon, 21 Dec 2020 13:52:15 +0100 Subject: [PATCH 3/3] Clean test log --- spec/EnableExpressErrorHandler.spec.js | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/EnableExpressErrorHandler.spec.js b/spec/EnableExpressErrorHandler.spec.js index fa73d21fb3..26483ec6a1 100644 --- a/spec/EnableExpressErrorHandler.spec.js +++ b/spec/EnableExpressErrorHandler.spec.js @@ -2,6 +2,7 @@ const request = require('../lib/request'); describe('Enable express error handler', () => { it('should call the default handler in case of error, like updating a non existing object', async done => { + spyOn(console, 'error'); const parseServer = await reconfigureServer( Object.assign({}, defaultConfiguration, { enableExpressErrorHandler: true,