From b9b3d17307cf89d00be73d7712f974173b85305f Mon Sep 17 00:00:00 2001 From: Diamond Lewis Date: Thu, 26 Jan 2023 15:29:39 -0600 Subject: [PATCH 1/3] fix: Cannot read property 'protectedFields' of undefined --- src/Controllers/DatabaseController.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Controllers/DatabaseController.js b/src/Controllers/DatabaseController.js index 3aa4da160e..1f533c5a50 100644 --- a/src/Controllers/DatabaseController.js +++ b/src/Controllers/DatabaseController.js @@ -220,8 +220,8 @@ const filterSensitiveData = ( protectedFields && protectedFields.forEach(k => delete object[k]); // fields not requested by client (excluded), - //but were needed to apply protecttedFields - perms.protectedFields && + // but were needed to apply protectedFields + perms && perms.protectedFields && perms.protectedFields.temporaryKeys && perms.protectedFields.temporaryKeys.forEach(k => delete object[k]); } From 1f8d3cd56b40424fc131d81bd58da211de4b8c15 Mon Sep 17 00:00:00 2001 From: Diamond Lewis Date: Thu, 26 Jan 2023 18:48:09 -0600 Subject: [PATCH 2/3] use optional chaining Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com> --- src/Controllers/DatabaseController.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Controllers/DatabaseController.js b/src/Controllers/DatabaseController.js index 1f533c5a50..e3ac5723ab 100644 --- a/src/Controllers/DatabaseController.js +++ b/src/Controllers/DatabaseController.js @@ -221,9 +221,7 @@ const filterSensitiveData = ( // fields not requested by client (excluded), // but were needed to apply protectedFields - perms && perms.protectedFields && - perms.protectedFields.temporaryKeys && - perms.protectedFields.temporaryKeys.forEach(k => delete object[k]); + perms?.protectedFields?.temporaryKeys?.forEach(k => delete object[k]); } for (const key in object) { From 0af88b56e8cc9cac7dd1312fc784a06297881033 Mon Sep 17 00:00:00 2001 From: Diamond Lewis Date: Thu, 26 Jan 2023 18:51:51 -0600 Subject: [PATCH 3/3] lint --- .flowconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/.flowconfig b/.flowconfig index e36f404424..955444c1c0 100644 --- a/.flowconfig +++ b/.flowconfig @@ -8,3 +8,4 @@ [options] suppress_comment= \\(.\\|\n\\)*\\@flow-disable-next +esproposal.optional_chaining=enable