Skip to content

Update Node.js minimum required version. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama opened this issue Apr 29, 2020 · 3 comments
Closed

Update Node.js minimum required version. #159

shisama opened this issue Apr 29, 2020 · 3 comments

Comments

@shisama
Copy link

shisama commented Apr 29, 2020

According to package.json, this package seems to support Node.js v8.

"node": ">=8.10.0"

However, Node.js v8 has already been end-of-life on Dec 31, 2019.

https://github.com/nodejs/Release

If it is Node.js v10.13, fs.promises can be used. It is available to use fs.Dirent too, which is faster than fs.stat to check whether an entry is a file or a directory.

Another idea is that the minimum required version will be Node.js v12 for #105 .
Node.js v12 has already been LTS.

If minimum required Node.js version is updated, it will be a breaking change.

Are you planning to update Node.js minimum required version?

@paulmillr
Copy link
Owner

Have you checked the actual readdirp code? We are using Dirent already. And we are using bigint inodes for win32, which are only available on node 10+.

We fallback to old methods for v8. Readdirp 3 was released one year ago, and so far we haven’t even switched half of users to it. The reason being: the packages support even older nodes, like v6. It’s a very lengthy task, and bumping min req to node10 won’t help much here.

@shisama
Copy link
Author

shisama commented Apr 29, 2020

Thank you for your reply. I did not know this has already used Dirent. I should have read code more carefully.
I understood what you wrote. So I will close this issue.
Thank you for your great works.

@shisama shisama closed this as completed Apr 29, 2020
@paulmillr
Copy link
Owner

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants