Even better optional Infinity version handling (#323)

* Return None instead of Undefined

* make print a warn

* makr warning a string

* update test too

Author: StijnKas

python/pdstools/infinity/internal/_base_client.py

@@ -2,6 +2,7 @@
 import json
 import logging
 import os
+import warnings
 from typing import (
     TYPE_CHECKING,
     Any,
@@ -107,12 +108,12 @@ def _get_version(self, repo):
         elif "repository_type" in repo:
             return "24.2"
         else:
-            print(
-                "Could not infer Pega version automatically. ",
-                "For full compatibility, please supply the pega_version argument",
-                "to the Infinity class.",
+            warnings.warn(
+                """Could not infer Pega version automatically.
+For full compatibility, please supply the pega_version argument to the Infinity class.
+""",
             )
-            return "Undefined"
+            return None
 
     @classmethod
     def from_client_id_and_secret(

python/tests/test_apis.py

@@ -53,7 +53,7 @@ def test_base_client(httpx_mock: HTTPXMock, monkeypatch):
     assert client.pega_version is None
     assert client._get_version({"repository_name": "Repo"}) == "24.1"
     assert client._get_version({"repository_type": "AWS"}) == "24.2"
-    assert client._get_version({"Pega Version": "Undefined"}) == "Undefined"
+    assert client._get_version({"Pega Version": "Undefined"}) is None
 
     with pytest.raises(ValueError):
         _base_client.BaseClient.from_basic_auth()