Skip to content

Commit 9118352

Browse files
committed
feat(errors): throw instances of Error
1 parent b8b9dc9 commit 9118352

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ module.exports = () => {
4242
return _.cloneDeep(levels);
4343
}
4444

45-
throw `unsupported log level: ${level}`;
45+
throw new Error(`unsupported log level: ${level}`);
4646
},
4747
isMessage: (level, pattern) => {
4848
if (levels.hasOwnProperty(level)) {
@@ -51,10 +51,10 @@ module.exports = () => {
5151
_.isRegExp(pattern) ? message.match(pattern) : message === pattern);
5252
}
5353

54-
throw 'pattern must be a regexp or string';
54+
throw new Error('pattern must be a regexp or string');
5555
}
5656

57-
throw `unsupported log level: ${level}`;
57+
throw new Error(`unsupported log level: ${level}`);
5858
}
5959
};
6060

test/index.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ test('unknown level parameter to getMessages should throw error', (t) => {
165165

166166
t.throws(
167167
rootLogger.getMessages.bind(null, 'unknown level'),
168-
/^unsupported log level: unknown level$/
168+
/^Error: unsupported log level: unknown level$/
169169
);
170170
t.end();
171171

@@ -220,7 +220,7 @@ test('unknown level parameter to hasMessages should throw error', (t) => {
220220

221221
t.throws(
222222
rootLogger.hasMessages.bind(null, 'unknown level'),
223-
/^unsupported log level: unknown level$/
223+
/^Error: unsupported log level: unknown level$/
224224
);
225225
t.end();
226226

@@ -281,11 +281,11 @@ test('isMessage should throw an error if the supplied pattern is not a valid reg
281281
rootLogger.getLevels().forEach((level) => {
282282
t.throws(
283283
rootLogger.isMessage.bind(null, level, 17.3),
284-
/^pattern must be a regexp or string$/
284+
/^Error: pattern must be a regexp or string$/
285285
);
286286
t.throws(
287287
rootLogger[`is${_.capitalize(level)}Message`].bind(null, 17.3),
288-
/^pattern must be a regexp or string$/
288+
/^Error: pattern must be a regexp or string$/
289289
);
290290
});
291291

@@ -298,7 +298,7 @@ test('unknown level parameter to isMessage should throw error', (t) => {
298298

299299
t.throws(
300300
rootLogger.isMessage.bind(null, 'unknown level'),
301-
/^unsupported log level: unknown level$/
301+
/^Error: unsupported log level: unknown level$/
302302
);
303303
t.end();
304304

0 commit comments

Comments
 (0)