Filter-Util-Call-1.59

Improve tests using FindBin for filter-util.pl [atoomic #9]

Add int casts, assert on 2GB limitation.

No m4 filter in CORE

Author: rurban

Porting/Maintainers.pl

@@ -756,7 +756,7 @@ package Maintainers;
     },
 
     'Filter::Util::Call' => {
-        'DISTRIBUTION' => 'RURBAN/Filter-1.58.tar.gz',
+        'DISTRIBUTION' => 'RURBAN/Filter-1.59.tar.gz',
         'FILES'        => q[cpan/Filter-Util-Call
                             pod/perlfilter.pod
                            ],

cpan/Filter-Util-Call/Call.pm

@@ -18,7 +18,7 @@ use warnings;
 
 our @ISA = qw(Exporter);
 our @EXPORT = qw( filter_add filter_del filter_read filter_read_exact) ;
-our $VERSION = "1.58" ;
+our $VERSION = "1.59" ;
 our $XS_VERSION = $VERSION;
 $VERSION = eval $VERSION;
 

cpan/Filter-Util-Call/Call.xs

@@ -3,7 +3,7 @@
  * 
  * Author   : Paul Marquess 
  * Date     : 2014-12-09 02:48:44 rurban
- * Version  : 1.58
+ * Version  : 1.59
  *
  *    Copyright (c) 1995-2011 Paul Marquess. All rights reserved.
  *    Copyright (c) 2011-2014 Reini Urban. All rights reserved.
@@ -66,7 +66,9 @@ filter_call(pTHX_ int idx, SV *buf_sv, int maxlen)
     while (1) {
 
 	/* anything left from last time */
-	if ((n = SvCUR(my_sv))) {
+
+        if ((n = SvCUR(my_sv))) {
+            assert(SvCUR(my_sv) < PERL_INT_MAX) ;
 
 	    out_ptr = SvPVX(my_sv) + BUF_OFFSET(my_sv) ;
 
@@ -146,7 +148,7 @@ filter_call(pTHX_ int idx, SV *buf_sv, int maxlen)
 	        croak("Filter::Util::Call - %s::filter returned %d values, 1 was expected \n", 
 			PERL_MODULE(my_sv), count ) ;
 
-	    n = POPi ;
+	    n = (IV)POPi ;
 
 	    if (fdebug)
 	        warn("status = %d, length op buf = %" IVdf " [%s]\n",
@@ -215,7 +217,7 @@ void
 real_import(object, perlmodule, coderef)
     SV *	object
     char *	perlmodule 
-    int		coderef
+    IV		coderef
     PPCODE:
     {
         SV * sv = newSV(1) ;

cpan/Filter-Util-Call/t/call.t

@@ -1,18 +1,22 @@
 use Config;
+
 BEGIN {
     if ($ENV{PERL_CORE}) {
         if ($Config{'extensions'} !~ m{\bFilter/Util/Call\b}) {
             print "1..0 # Skip: Filter::Util::Call was not built\n";
             exit 0;
         }
     }
-    unshift @INC, 't';
-    require 'filter-util.pl';
 }
 
 use strict;
 use warnings;
 
+use FindBin;
+use lib "$FindBin::Bin"; # required to load filter-util.pl
+
+require 'filter-util.pl';
+
 use vars qw($Inc $Perl);
 
 print "1..34\n";

cpan/Filter-Util-Call/t/rt_54452-rebless.t

@@ -8,7 +8,9 @@ if ($] < 5.004_55) {
 
 use strict;
 use warnings;
-BEGIN { unshift @INC, 't'; }
+
+use FindBin;
+use lib "$FindBin::Bin"; # required to load filter-util.pl
 
 require "filter-util.pl" ;
 

dist/Module-CoreList/lib/Module/CoreList.pm

@@ -17222,6 +17222,7 @@ for my $version ( sort { version_sort($a, $b) } keys %released ) {
             'ExtUtils::ParseXS::Eval' => '3.36_03',
             'ExtUtils::ParseXS::Utilities'=> '3.36_03',
             'File::Temp'            => '0.2308',
+            'Filter::Util::Call'    => '1.59',
             'Hash::Util'            => '0.22_01',
             'I18N::LangTags'        => '0.42_01',
             'IO'                    => '1.38_01',

pod/perlcdelta.pod

@@ -1538,12 +1538,16 @@ In this case it should simply not filter anything.
 
 - update distribution tooling
 
-=item L<Filter::Util::Call> 1.58
+=item L<Filter::Util::Call> 1.59
 
 XSLoader, our. defer Carp.
 
 Add filter_read_exact tests.
 
+Improve tests using FindBin for filter-util.pl [atoomic #9]
+
+Add int casts, assert on 2GB limitation.
+
 =item L<GDBM_File> 1.17
 
 Its documentation now explains that C<each> and C<delete> don't mix in