fix gateway crashes

Author: patinthehat

lib/gateway/gateway.go

@@ -63,8 +63,11 @@ func New(deniedDomains, allowedDomains, blockedFileExts, allowedFileExts []strin
 func (g *Gateway) setup() {
 	// we need the `validateUrl` middleware no matter what, so prepend it to the list of enabled middleware.
 	// this middleware is the core functionality of the http gateway's allow/block lists.
-	temp := []string{"validateUrl"}
-	g.EnabledMiddleware = append(temp, g.EnabledMiddleware...)
+	// temp := []string{"validateUrl"}
+	g.EnabledMiddleware = append(g.EnabledMiddleware, "validateUrl")
+	GatewayMiddleware.AddPreMiddleware(&ValidateUrlMiddleware)
+
+	// fmt.Printf("enabled middleware: %v\n", g.EnabledMiddleware)
 
 	for _, name := range g.EnabledMiddleware {
 		if !GatewayMiddleware.HasMiddleware(name) {
@@ -224,6 +227,7 @@ func (g *Gateway) runUrlRequestPipeline(link string) error {
 
 	for _, mw := range g.Middleware {
 		if err := (*mw).Handler(g, link); err != nil {
+			// fmt.Printf("error on mw: %v; %v\n", mw.Name, err)
 			return err
 		}
 	}

lib/gateway/gateway_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	"github.com/stackup-app/stackup/lib/gateway"
+	"github.com/stackup-app/stackup/lib/settings"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -23,6 +24,49 @@ func TestGatewayDisable(t *testing.T) {
 
 func TestGatewayAllowed(t *testing.T) {
 	g := gateway.New([]string{}, []string{"*.example.com", "*.one.example.net", "api.**.com"}, []string{}, []string{})
+	verifyChecksums := true
+	enableStats := false
+	gatewayAllow := "allow"
+	s := &settings.Settings{
+		AnonymousStatistics:  &enableStats,
+		DotEnvFiles:          []string{".env"},
+		Cache:                &settings.WorkflowSettingsCache{TtlMinutes: 15},
+		ChecksumVerification: &verifyChecksums,
+		Domains: &settings.WorkflowSettingsDomains{
+			Allowed: []string{"*.example.com", "*.one.example.net", "api.**.com"},
+			Hosts: []settings.WorkflowSettingsDomainsHosts{
+				{Hostname: "raw.githubusercontent.com", Gateway: &gatewayAllow, Headers: nil},
+				{Hostname: "api.github.com", Gateway: &gatewayAllow, Headers: nil},
+			},
+		},
+		Defaults: &settings.WorkflowSettingsDefaults{
+			Tasks: &settings.WorkflowSettingsDefaultsTasks{
+				Silent:    false,
+				Path:      "./",
+				Platforms: []string{"windows", "linux", "darwin"},
+			},
+		},
+		Gateway: &settings.WorkflowSettingsGateway{
+			ContentTypes: &settings.GatewayContentTypes{
+				Blocked: []string{},
+				Allowed: []string{"*"},
+			},
+			FileExtensions: &settings.WorkflowSettingsGatewayFileExtensions{
+				Allow: []string{"*"},
+				Block: []string{},
+			},
+			Middleware: []string{},
+		},
+		Notifications: &settings.WorkflowSettingsNotifications{
+			Telegram: &settings.WorkflowSettingsNotificationsTelegram{
+				APIKey:  "",
+				ChatIds: []string{},
+			},
+		},
+	}
+	gateway.GatewayMiddleware.AddPreMiddleware(&gateway.ValidateUrlMiddleware)
+
+	g.Initialize(s, nil, nil)
 	assert.True(t, g.Allowed("https://www.example.com"), "www.example.com should be allowed")
 	assert.True(t, g.Allowed("https://example.com"), "example.com should be allowed")
 	assert.False(t, g.Allowed("https://www.example.net"), "www.example.net should not be allowed")

lib/gateway/middleware.go

@@ -1,6 +1,8 @@
 package gateway
 
-import "strings"
+import (
+	"strings"
+)
 
 type GatewayMiddlewareStore struct {
 	PreMiddleware  []*GatewayUrlRequestMiddleware