update remote domain gatekeeper

Author: patinthehat

lib/app/app.go

@@ -304,13 +304,13 @@ func (a *Application) createNewConfigFile() {
 }
 
 func (a *Application) checkForApplicationUpdates() {
-	if a.Gatekeeper.CanAccessUrl(updater.GetUpdateCheckUrlFormat()) {
-		updateAvailable := updater.IsLatestApplicationReleaseNewerThanCurrent(version.APP_VERSION, "permafrost-dev/stackup")
+	// if a.Gatekeeper.CanAccessUrl(updater.GetUpdateCheckUrlFormat()) {
+	updateAvailable := updater.IsLatestApplicationReleaseNewerThanCurrent(version.APP_VERSION, "permafrost-dev/stackup")
 
-		if updateAvailable {
-			support.WarningMessage("A new version of StackUp is available. Please update to the latest version.")
-		}
+	if updateAvailable {
+		support.WarningMessage("A new version of StackUp is available. Please update to the latest version.")
 	}
+	// }
 }
 
 func (a *Application) handleFlagOptions() {

lib/app/gatekeeper.go

@@ -20,6 +20,14 @@ func (g *Gatekeeper) Initialize() {
 }
 
 func (g *Gatekeeper) CanAccessUrl(urlStr string) bool {
+	if !g.Enabled {
+		return true
+	}
+
+	if App.Workflow.Settings.Domains.Allowed == nil {
+		return true
+	}
+
 	for _, domain := range App.Workflow.Settings.Domains.Allowed {
 		parsedUrl, _ := url.Parse(urlStr)
 

lib/app/workflow.go

@@ -421,10 +421,16 @@ func (workflow *StackupWorkflow) Initialize() {
 	// ensure that the allowed domains are in the correct format, i.e. without a protocol or port
 	tempDomains := []string{}
 	for _, domain := range workflow.Settings.Domains.Allowed {
-		parsedUrl, _ := url.Parse(domain)
-		tempDomains = append(tempDomains, parsedUrl.Host)
+		if strings.Contains(domain, "://") {
+			parsedUrl, _ := url.Parse(domain)
+			tempDomains = append(tempDomains, parsedUrl.Host)
+		} else {
+			tempDomains = append(tempDomains, domain)
+		}
 	}
-	workflow.Settings.Domains.Allowed = tempDomains
+
+	copy(workflow.Settings.Domains.Allowed, tempDomains)
+	// workflow.Settings.Domains.Allowed = tempDomains
 
 	// initialize the includes
 	for _, inc := range workflow.Includes {