fix broken tests

Author: patinthehat

lib/gateway/gateway_test.go

@@ -7,7 +7,6 @@ import (
 	"github.com/stackup-app/stackup/lib/gateway"
 	"github.com/stackup-app/stackup/lib/scripting"
 	"github.com/stackup-app/stackup/lib/settings"
-	"github.com/stackup-app/stackup/lib/types"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -40,9 +39,9 @@ func TestGatewayInitialize(t *testing.T) {
 	g := gateway.New(nil)
 	findTask := func(id string) (any, error) { return nil, nil }
 	engine := scripting.CreateNewJavascriptEngine(&sync.Map{}, g, findTask, func() string { return "." })
-	var engineIntf interface{} = engine
-	var engineContract types.JavaScriptEngineContract = engineIntf.(types.JavaScriptEngineContract)
-	g.Initialize(s, engineContract, nil)
+	// var engineIntf interface{} =
+	// var engineContract types.JavaScriptEngineContract = engineIntf.(types.JavaScriptEngineContract)
+	g.Initialize(s, engine.AsContract(), nil)
 
 	assert.True(t, g.Enabled, "gateway should be enabled")
 	assert.Equal(t, 3, len(g.AllowedDomains), "gateway should have 3 allowed domains")

lib/scripting/scriptEngine.go

@@ -79,8 +79,9 @@ func (e *JavaScriptEngine) Initialize(appVars *sync.Map, environ []string) {
 	e.CreateEnvironmentVariables(environ)
 }
 
-func (e *JavaScriptEngine) GetFindTaskById(id string) (any, error) {
-	return e.FindTaskById(id)
+func (e JavaScriptEngine) GetFindTaskById(id string) (any, bool) { //GetFindTaskById(id string) (any, error) {
+	result, err := e.FindTaskById(id)
+	return result, err == nil
 }
 
 func (e *JavaScriptEngine) initializeExtensions() {