Skip to content

Commit 3282a8c

Browse files
committed
Add macos-14 to test_python matrix
macos-14 is aarch64 with Apple silicon. This lets us test the aarch64 wheel in CI may try a follow up to see if the builds are any faster on macos-14. Will probably want to double check we still have a good value for `CMAKE_OSX_DEPLOYMENT_TARGET`/`MACOSX_DEPLOYMENT_TARGET` if upgrading the builders Signed-off-by: Tom Jakubowski <tom@prospective.dev>
1 parent 9eee20f commit 3282a8c

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

.github/workflows/build.yaml

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -592,18 +592,28 @@ jobs:
592592
os:
593593
- ubuntu-22.04
594594
- macos-13
595+
- macos-14
595596
- windows-2022
596597
python-version:
597598
- 3.9
598599
# - 3.12
599600
node-version: [20.x]
600601
is-release:
601602
- ${{ startsWith(github.ref, 'refs/tags/v') }}
602-
arch:
603-
- x86_64
603+
include:
604+
- os: ubuntu-22.04
605+
arch: x86_64
606+
- os: macos-13
607+
arch: x86_64
608+
- os: macos-14
609+
arch: aarch64
610+
- os: windows-2022
611+
arch: x86_64
604612
exclude:
605613
- os: macos-13
606614
is-release: false
615+
- os: macos-14
616+
is-release: false
607617
- os: windows-2022
608618
is-release: false
609619
steps:
@@ -623,7 +633,8 @@ jobs:
623633

624634
- uses: actions/download-artifact@v4
625635
with:
626-
name: perspective-python-dist-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.python-version }}
636+
# the macos-14 runner tests artifacts built on macos-13
637+
name: perspective-python-dist-${{ matrix.arch }}-${{ matrix.os == 'macos-14' && 'macos-13' || matrix.os }}-${{ matrix.python-version }}
627638

628639
- uses: ./.github/actions/install-wheel
629640

0 commit comments

Comments
 (0)