Merge pull request #1418 from finos/zero-color-bug

texodus · web-flow · commit 569c1ed28822 · 2021-05-11T00:53:44.000-04:00
Fix color gradient charts containing 0
diff --git a/packages/perspective-viewer-d3fc/src/js/data/treeData.js b/packages/perspective-viewer-d3fc/src/js/data/treeData.js
@@ -31,7 +31,7 @@ export function treeData(settings) {
                 if (settings.realValues.length > 1 && settings.realValues[1] !== null) {
                     const is_leaf = i === groups.length - 1;
                     const colorValue = is_leaf ? getDataValue(d, settings.mainValues[1], split) : getDataValue(settings.agg_paths[j][i + 1] || d, settings.mainValues[1], split);
-                    if (colorValue) {
+                    if (colorValue !== undefined) {
                         element.color = colorValue;
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export function treeData(settings) {`
`31`	`31`	`if (settings.realValues.length > 1 && settings.realValues[1] !== null) {`
`32`	`32`	`const is_leaf = i === groups.length - 1;`
`33`	`33`	`const colorValue = is_leaf ? getDataValue(d, settings.mainValues[1], split) : getDataValue(settings.agg_paths[j][i + 1] \|\| d, settings.mainValues[1], split);`
`34`		`- if (colorValue) {`
	`34`	`+ if (colorValue !== undefined) {`
`35`	`35`	`element.color = colorValue;`
`36`	`36`	`}`
`37`	`37`	`}`