Skip to content

Commit 5bc7bd0

Browse files
authored
Merge pull request #1943 from finos/crates-pub
Per-component CSS model
2 parents 4949bd4 + a7b54e3 commit 5bc7bd0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+1171
-692
lines changed

.eslintrc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
2-
"parser": "babel-eslint",
32
"plugins": ["markdown", "prettier"],
43
"env": {
54
"browser": true,
@@ -10,7 +9,7 @@
109
"jest": true
1110
},
1211
"parserOptions": {
13-
"ecmaVersion": 2017,
12+
"ecmaVersion": 2020,
1413
"ecmaFeatures": {},
1514
"sourceType": "module",
1615
"experimentalObjectRestSpread": true

examples/blocks/src/streaming/streaming.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,6 @@ window.addEventListener("DOMContentLoaded", async function () {
9090
// Add more rows every 50ms using the `update()` method on the `table` directly.
9191
(function postRow() {
9292
table.update(newRows());
93-
setTimeout(postRow, 50);
93+
setTimeout(postRow, 10);
9494
})();
9595
});

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,9 @@
3030
"@babel/core": "^7.8.4",
3131
"@babel/preset-env": "^7.8.4",
3232
"@types/ws": "^7.2.2",
33-
"@typescript-eslint/eslint-plugin": "^4.31.0",
33+
"@typescript-eslint/eslint-plugin": "^5.33.1",
3434
"@typescript-eslint/parser": "^4.31.0",
3535
"arraybuffer-loader": "^1.0.2",
36-
"babel-eslint": "^10.0.3",
3736
"babel-jest": "^25.1.0",
3837
"chalk": "^2.4.2",
3938
"cpy-cli": "^3.1.1",
@@ -45,10 +44,10 @@
4544
"dotenv": "^8.1.0",
4645
"esbuild": "^0.13.12",
4746
"esbuild-plugin-less": "^1.1.5",
48-
"eslint": "^7.32.0",
49-
"eslint-config-prettier": "^8.3.0",
50-
"eslint-plugin-markdown": "^2.2.0",
51-
"eslint-plugin-prettier": "^4.0.0",
47+
"eslint": "^8.22.0",
48+
"eslint-config-prettier": "^8.5.0",
49+
"eslint-plugin-markdown": "^3.0.0",
50+
"eslint-plugin-prettier": "^4.2.1",
5251
"fs-extra": "^8.1.0",
5352
"html-loader": "^0.5.1",
5453
"html-loader-jest": "^0.2.1",
@@ -71,12 +70,13 @@
7170
"octokit": "^1.7.2",
7271
"postcss": "^8",
7372
"postcss-loader": "^7",
74-
"prettier": "^2.4.0",
73+
"prettier": "^2.7.1",
7574
"puppeteer": "^13.1.3",
7675
"rimraf": "^2.6.2",
7776
"sinon": "^7.3.1",
7877
"style-loader": "^0.18.2",
7978
"term-img": "^4.1.0",
79+
"tiny-glob": "^0.2.9",
8080
"ts-loader": "^6.2.0",
8181
"typedoc": "^0.22.7",
8282
"typedoc-plugin-markdown": "^3.11.6",

packages/perspective-workspace/src/js/workspace/workspace.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -350,11 +350,11 @@ export class PerspectiveWorkspace extends SplitPanel {
350350
if (master || this.mode === MODE.LINKED) {
351351
widget.viewer.addEventListener(
352352
"perspective-select",
353-
this.onPerspectiveSelect
353+
this.onPerspectiveSelect.bind(this)
354354
);
355355
widget.viewer.addEventListener(
356356
"perspective-click",
357-
this.onPerspectiveSelect
357+
this.onPerspectiveSelect.bind(this)
358358
);
359359
// TODO remove event listener
360360
this.masterPanel.addWidget(widget);
@@ -534,7 +534,7 @@ export class PerspectiveWorkspace extends SplitPanel {
534534
await viewer.restore({filter: newFilters});
535535
}
536536

537-
onPerspectiveSelect = async (event) => {
537+
async onPerspectiveSelect(event) {
538538
const config = await event.target.save();
539539
// perspective-select is already handled for hypergrid
540540

@@ -562,7 +562,7 @@ export class PerspectiveWorkspace extends SplitPanel {
562562
this._filterViewer(widget.viewer, filters, candidates)
563563
);
564564
}
565-
};
565+
}
566566

567567
async makeMaster(widget) {
568568
widget.master = true;
@@ -582,11 +582,11 @@ export class PerspectiveWorkspace extends SplitPanel {
582582
widget.viewer.restyleElement();
583583
widget.viewer.addEventListener(
584584
"perspective-click",
585-
this.onPerspectiveSelect
585+
this.onPerspectiveSelect.bind(this)
586586
);
587587
widget.viewer.addEventListener(
588588
"perspective-select",
589-
this.onPerspectiveSelect
589+
this.onPerspectiveSelect.bind(this)
590590
);
591591
}
592592

@@ -605,11 +605,11 @@ export class PerspectiveWorkspace extends SplitPanel {
605605
widget.viewer.restyleElement();
606606
widget.viewer.removeEventListener(
607607
"perspective-click",
608-
this.onPerspectiveSelect
608+
this.onPerspectiveSelect.bind(this)
609609
);
610610
widget.viewer.removeEventListener(
611611
"perspective-select",
612-
this.onPerspectiveSelect
612+
this.onPerspectiveSelect.bind(this)
613613
);
614614
}
615615

@@ -971,7 +971,7 @@ export class PerspectiveWorkspace extends SplitPanel {
971971
widget.viewer.addEventListener("perspective-config-update", updated);
972972
widget.viewer.addEventListener(
973973
"perspective-plugin-update",
974-
this.workspaceUpdated
974+
this.workspaceUpdated.bind(this)
975975
);
976976

977977
widget.title.changed.connect(updated);
@@ -987,7 +987,7 @@ export class PerspectiveWorkspace extends SplitPanel {
987987
);
988988
widget.viewer.removeEventListener(
989989
"perspective-plugin-update",
990-
this.workspaceUpdated
990+
this.workspaceUpdated.bind(this)
991991
);
992992
widget.title.changed.disconnect(updated);
993993
});
@@ -1021,7 +1021,7 @@ export class PerspectiveWorkspace extends SplitPanel {
10211021
}
10221022
}
10231023

1024-
workspaceUpdated = () => {
1024+
async workspaceUpdated() {
10251025
if (!this._save) {
10261026
this._save = debounce(
10271027
() =>
@@ -1031,5 +1031,5 @@ export class PerspectiveWorkspace extends SplitPanel {
10311031
);
10321032
}
10331033
this._save();
1034-
};
1034+
}
10351035
}

0 commit comments

Comments
 (0)