Replace monaco

Author: texodus

.github/workflows/build.yml

@@ -287,6 +287,8 @@ jobs:
       uses: actions-rs/toolchain@v1
       with:
           toolchain: nightly
+          target: wasm32-unknown-unknown
+          default: true
           override: true
           components: rustfmt, clippy, rust-src
 
@@ -620,6 +622,17 @@ jobs:
     - name: Install python dependencies
       run: yarn _requires_python
 
+
+    ################
+    # Rust
+    - name: Install latest nightly rust
+      uses: actions-rs/toolchain@v1
+      with:
+        toolchain: nightly
+        target: wasm32-unknown-unknown
+        default: true
+        override: true
+
     ################
     # Wasm
     - name: Install wasm-pack (Linux and Macos)

cpp/perspective/src/cpp/computed_expression.cpp

@@ -346,8 +346,8 @@ t_computed_expression_parser::get_dtype(const std::string& expression_alias,
             std::string error_message(parser_error.diagnostic.c_str());
 
             // strip the Exprtk error codes such as "ERR001 -"
-            error.m_error_message = "Parser Error "
-                + error_message.substr(error_message.find("- "));
+            error.m_error_message
+                = error_message.substr(error_message.find("- ") + 2);
 
             error.m_line = parser_error.line_no;
             error.m_column = parser_error.column_no;

docs/docs/js.md

@@ -57,7 +57,6 @@ performance, as the plugin-assisted bundle version of Perspective:
 -   Downloads `.wasm` and `.js` assets in parallel.
 -   Compiles `.wasm` incrementally via
     [streaming instantiation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiateStreaming).
--   Lazily downloads large features only when used such as `monaco-editor`.
 -   overall bundle size is ~20% smaller (due to bas64 encoding overhead).
 
 Perspective comes with bundler plugins for:
@@ -83,28 +82,6 @@ module.exports = {
 };
 ```
 
-`@finos/perspective-viewer` has a dependence on
-[`monaco-editor`](https://microsoft.github.io/monaco-editor/), which itself
-depends on several CSS assets. If your webpack config uses a loader for
-`"*.css"` or similar, you may need to exclude `monaco-editor` from this loader
-to prevent double-encoding:
-
-```javascript
-module.exports = {
-    // ...
-
-    module: {
-        rules: [
-            {
-                test: /\.css$/,
-                exclude: [/monaco-editor/], // <- Exclude `monaco-editor`
-                use: [{loader: "style-loader"}, {loader: "css-loader"}],
-            },
-        ],
-    },
-};
-```
-
 ##### `esbuild`
 
 Applications bundled with `esbuild` can make use of the

docs/plugins/perspective-loader/index.js

@@ -6,7 +6,7 @@ module.exports = function (context, options) {
         configureWebpack(config, isServer) {
             config.module.rules.map((x) => {
                 if (x.test.toString() === "/\\.css$/i") {
-                    x.exclude = [/\.module\.css$/i, /@finos/i, /monaco/i];
+                    x.exclude = [/\.module\.css$/i, /@finos/i];
                 }
             });
 

examples/blocks/src/editable/index.html

@@ -23,7 +23,6 @@
         <link rel="preload" href="/node_modules/@finos/perspective-viewer/dist/cdn/perspective_bg.wasm" as="fetch" type="application/wasm" crossorigin="anonymous" />
         <link rel="preload" href="/node_modules/superstore-arrow/superstore.arrow" as="fetch" type="arraybuffer" crossorigin="anonymous" />
         <link rel="preload" href="/node_modules/@finos/perspective/dist/cdn/perspective.worker.js" as="fetch" type="application/javascript" crossorigin="anonymous" />
-        <link rel="preload" href="/node_modules/@finos/perspective-viewer/dist/cdn/editor.worker.js" as="fetch" type="application/javascript" crossorigin="anonymous" />
 
         <script type="module">
             import {worker} from "/node_modules/@finos/perspective/dist/cdn/perspective.js";