Merge pull request #178 from redbearsam/fix/sunburst-zero

Ro4052 · web-flow · commit bd39ee2a3290 · 2019-04-18T16:17:01.000+01:00
Treat negative sunburst size values as zero
diff --git a/packages/perspective-viewer-d3fc/src/js/data/treeData.js b/packages/perspective-viewer-d3fc/src/js/data/treeData.js
@@ -33,7 +33,8 @@ export function treeData(settings) {
                 if (i === groups.length - 1) {
                     element.name = groups.slice(-1)[0];
                     if (groups.length === settings.crossValues.length) {
-                        element.size = getDataValue(d, settings.mainValues[0], split);
+                        const size = getDataValue(d, settings.mainValues[0], split);
+                        element.size = size > 0 ? size : 0;
                     }
                 }
                 currentLevel = element.children;

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,8 @@ export function treeData(settings) {`
`33`	`33`	`if (i === groups.length - 1) {`
`34`	`34`	`element.name = groups.slice(-1)[0];`
`35`	`35`	`if (groups.length === settings.crossValues.length) {`
`36`		`- element.size = getDataValue(d, settings.mainValues[0], split);`
	`36`	`+ const size = getDataValue(d, settings.mainValues[0], split);`
	`37`	`+ element.size = size > 0 ? size : 0;`
`37`	`38`	`}`
`38`	`39`	`}`
`39`	`40`	`currentLevel = element.children;`