Amalgam of conda patches and build fixes

Did this work a bit out of order so squashed it all into one commit.

Conda related:
- switch to BUNDLED arrow dependency source
  - this lets us remove our direct deps on lz4, flatbuffers, zstd
- add abi3 feature to crate + enable unless CONDA_BUILD is set
- when CONDA_BUILD is set, pass PYTHON to maturin build
  --interpeter flag
- remove vestigal use of CMAKE_ARGS from .txt.in files
- parse CMAKE_ARGS from environment (unrelated to above item)
  - this is so we pick up the cross-compiling toolchain (i.e.
    CMAKE_LIBTOOL) in conda

Not conda related:
- switch away from global include_directories() calls
  - these add include paths to every target, including our dependencies
  - instead, export lists of INCLUDE_DIRS from every dependency,
    and then assemble them into a list to be passed to
    `target_include_directories` on the psp and perspective_esm targets
  - decouples order of psp_build_dep() calls and order of include
    directories
- switch Boost from a system dependency to psp_build_dep
  - eventually, to support Conda, we'll add a "use system dependency"
    feature to psp_build_dep for all dependencies
  - caveat: the boost download is a bit slow

Signed-off-by: Tom Jakubowski <tom@prospective.dev>

Author: tomjakubowski

.github/actions/install-deps/action.yaml

@@ -111,7 +111,6 @@ runs:
         #   with:
         #       key: ${{ github.job }}-${{ matrix.os }}
 
-        # TODO this should move to `install_tools.mjs`
         - name: Windows init steps (vc143)
           id: vcpkg-step
           shell: pwsh
@@ -220,17 +219,6 @@ runs:
               fi
           if: ${{ runner.os == 'Linux' && inputs.cpp == 'true' && inputs.javascript == 'false' }}
 
-        # TODO do this earlier?
-        - name: Linux init steps
-          shell: bash
-          run: node tools/perspective-scripts/install_tools.mjs
-          if: ${{ runner.os != 'Windows' && inputs.cpp == 'true' && inputs.manylinux == 'true' }}
-
-        - name: Linux init steps
-          shell: bash
-          run: sudo node tools/perspective-scripts/install_tools.mjs
-          if: ${{ runner.os != 'Windows' && inputs.cpp == 'true' && inputs.manylinux  == 'false' }}
-
         - name: Install Python Pyodide dependencies
           shell: bash
           run: python -m pip install -r rust/perspective-python/requirements-pyodide.txt

.github/workflows/build.yaml

@@ -250,6 +250,7 @@ jobs:
               if: ${{ contains(matrix.os, 'windows') }}
               env:
                   CARGO_TARGET_DIR: D:\psp-rust
+                  PSP_CPP_BUILD_DIR: D:\psp-build
                   PSP_ROOT_DIR: ${{ github.workspace }}
                   PACKAGE: "perspective-python"
                   PSP_ARCH: ${{ matrix.arch }}

.prettierignore

@@ -3,11 +3,12 @@ build/
 node_modules/
 target/
 .emsdk/
+.venv*/
 boost*/
 py_modules/
 ts-rs/
 rust/perspective-python/perspective/labextension/
 rust/perspective-python/perspective.data/
 rust/perspective-python/*/data
 expression_gen.md
-rust/perspective-viewer/docs/exprtk.md
+rust/perspective-viewer/docs/exprtk.md

Cargo.lock

@@ -23,9 +23,6 @@ automatically call the correct build and test tools.
 dependencies to be installed:
 
 -   [CMake](https://cmake.org/) (version 3.29.5 or higher)
--   [Boost](https://www.boost.org/) (version 1.83 or highery). This can be
-    installed from tarball with the included script
-    `node tools/perspective-scripts/install_tools.mjs`.
 -   [pnpm](https://pnpm.io/).
 
 **_This list may be non-exhaustive depending on your OS/environment; please open

DEVELOPMENT.md

@@ -0,0 +1,18 @@
+cmake_minimum_required(VERSION 3.7.2)
+
+project(Boost-download NONE)
+
+# Makes GIT_SUBMODULES "" in ExternalProject_Add skip initializing submodules
+cmake_policy(SET CMP0097 NEW)
+
+include(ExternalProject)
+ExternalProject_Add(Boost
+  URL               "https://boostorg.jfrog.io/artifactory/main/release/1.82.0/source/boost_1_82_0.tar.gz"
+  SOURCE_DIR        "${CMAKE_BINARY_DIR}/Boost-src"
+  BINARY_DIR        "${CMAKE_BINARY_DIR}/Boost-build"
+  SOURCE_SUBDIR     ""
+  CONFIGURE_COMMAND ""
+  BUILD_COMMAND     ""
+  INSTALL_COMMAND   ""
+  TEST_COMMAND      ""
+)

cmake/Boost.txt.in

@@ -12,5 +12,4 @@ ExternalProject_Add(pybind11
   BUILD_COMMAND     ""
   INSTALL_COMMAND   ""
   TEST_COMMAND      ""
-  CMAKE_ARGS        " -DCMAKE_MODULE_PATH=${CMAKE_MODULE_PATH} -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}"
 )

cmake/Pybind.txt.in

@@ -2,21 +2,23 @@ cmake_minimum_required(VERSION 3.7.2)
 
 project(arrow-download NONE)
 
-# *******************************************************************
-# NOTE: this depedency's CMakeLists.txt is overloaded, make sure to
-# adjust if you update the tag
-# *******************************************************************
+# Makes GIT_SUBMODULES "" in ExternalProject_Add skip initializing submodules
+cmake_policy(SET CMP0097 NEW)
 
 include(ExternalProject)
 ExternalProject_Add(apachearrow
   GIT_REPOSITORY    https://github.com/apache/arrow.git
   GIT_TAG           apache-arrow-17.0.0
+  GIT_SUBMODULES    ""
+  GIT_SHALLOW       TRUE
   SOURCE_DIR        "${CMAKE_BINARY_DIR}/arrow-src"
   BINARY_DIR        "${CMAKE_BINARY_DIR}/arrow-build"
   SOURCE_SUBDIR     "cpp"
   CONFIGURE_COMMAND ""
   BUILD_COMMAND     ""
   INSTALL_COMMAND   ""
   TEST_COMMAND      ""
-  CMAKE_ARGS        "-DFLATBUFFERS_BUILD_TESTS=OFF -DCMAKE_MODULE_PATH=${CMAKE_MODULE_PATH} -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}"
+  # This patch is to work around https://github.com/apache/arrow/issues/44384
+  # It can be removed when a version of Arrow is released with https://github.com/apache/arrow/pull/44385
+  PATCH_COMMAND     ${CMAKE_COMMAND} -E chdir <SOURCE_DIR> git apply ${CMAKE_SOURCE_DIR}/patches/fix_arrow_libtool.patch
 )

cmake/arrow.txt.in

@@ -12,5 +12,4 @@ ExternalProject_Add(date
   BUILD_COMMAND     ""
   INSTALL_COMMAND   ""
   TEST_COMMAND      ""
-  CMAKE_ARGS        " -DCMAKE_MODULE_PATH=${CMAKE_MODULE_PATH} -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}"
 )