Skip to content

Incremental search and highlights #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vozf opened this issue Jan 14, 2020 · 5 comments
Open

Incremental search and highlights #3469

Vozf opened this issue Jan 14, 2020 · 5 comments

Comments

@Vozf
Copy link

Vozf commented Jan 14, 2020

Are there any plans to adopt commands for incremental search and highlighting such as

set incsearch
set hlsearch

?

@gdh1995
Copy link
Contributor

gdh1995 commented Jan 23, 2020

Browsers don't allow extensions to call their inner functionality of highlighting all matched text, while it's too complex and difficult to simulate such a highlighting style by Vimium itself.

@Vozf
Copy link
Author

Vozf commented Jan 23, 2020

There is an extension which works in a similar way.
If it helps - https://chrome.google.com/webstore/detail/selection-highlighter/nepmkgohgoagfgcoegjaggacodcpdibj

@Vozf Vozf closed this as completed Jan 23, 2020
@Vozf Vozf reopened this Jan 23, 2020
@gdh1995
Copy link
Contributor

gdh1995 commented Jan 24, 2020

The extension is hosted on https://github.com/neaumusic/selection-highlighter, and it creates new DOM elements to add styles to matched text. This behavior may break some pages - this may be why it has a blacklistedHosts.

Well, this issue is somehow a duplicate of #591, and there seems no perfect API to do so.

@Vozf
Copy link
Author

Vozf commented Jan 24, 2020

Can it be done as an optional feature with the same blacklist as vimium already has?

@Xiao6
Copy link

Xiao6 commented Apr 13, 2020

Add usecase why this is helpful: I need to view log file from logging apps, the log is usually large. Chrome default search can highlight all search appearances, and also has outline in the right scroll bar, it makes is easy to navigate the log. I don't quite use vimium search function because of lacking this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants