Skip to content

Highlight scroll hints with another color #4675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krasav4k1 opened this issue Apr 9, 2025 · 2 comments
Open

Highlight scroll hints with another color #4675

Krasav4k1 opened this issue Apr 9, 2025 · 2 comments

Comments

@Krasav4k1
Copy link

Is it possible to add some functionality to switch scroll if the website has multiple?
I know that when you call LinkHints by 'f' it also select shows you window with scroll which you can switch, but on some websites there are a lot of hints and difficult to find the hint which is responsible to switching the scroll.
With using Use the link's name and characters for link-hint filtering it's easier to switch scroll, because it show hint with name scroll, but if I don't want to enable link-hint filtering.

I would expect hints which related to scroll show in different color, to make them noticeable.
Or maybe automatically assign number for scroll, if you don't use link-hint filtering.

@danielcovill
Copy link

danielcovill commented Apr 21, 2025

With using Use the link's name and characters for link-hint filtering it's easier to switch scroll, because it show hint with name scroll, but if I don't want to enable link-hint filtering.

This is something that's bothered me as well. I never understood why you have to use link-hint mode to get "Frame:" and "Scroll:" appended to the link. If we add those tips to the markers in default mode, I think it would solve this problem, but it seems like there might be a reason that's not already done. If there's no objection, I might try to implement that.

Edit: Looks like this comes up a lot. I see the following frequently

In Vimium, currently only clicking an element (via LinkHints.activate or a real mouse) can notify Vimium it's scrollable, although this notifying can be easily imported into LinkHints.activateMode with action=hover (which means to "select" an element without clicking).
#3216

So there's some technical limitation at play, but I still don't understand why it works in one mode but not the other...

@danielcovill
Copy link

danielcovill commented Apr 27, 2025

I can't find a good reason why the solutions for Alphabet hints and Filter hints are different. Adding a color changes things a bit and I'm new to contributing here, but just showing the "Scroll." and "Frame." tips is helpful and with a minor tweak seems like it can be available to both. I'll put in a PR for this and hopefully it'll either either be accepted or we'll find out what I'm missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants