Skip to content

Commit d659c63

Browse files
committed
Merge pull request #90 from tdakkota/fix-gomap
Fix gomap datarace
2 parents dee1d39 + 6757d68 commit d659c63

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

gomap/gomap.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ func (s Store) Delete(k string) error {
6565
return err
6666
}
6767

68+
s.lock.Lock()
69+
defer s.lock.Unlock()
6870
delete(s.m, k)
6971
return nil
7072
}

test/test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,4 +353,14 @@ func InteractWithStore(store gokv.Store, key string, t *testing.T, waitGroup *sy
353353
if err != nil {
354354
t.Error(err)
355355
}
356+
// Delete
357+
err = store.Delete(key)
358+
if err != nil {
359+
t.Error(err)
360+
}
361+
// Read
362+
_, err = store.Get(key, new(Foo))
363+
if err != nil {
364+
t.Error(err)
365+
}
356366
}

0 commit comments

Comments
 (0)