Merge pull request #154 from php-enqueue/do-not-throw-on-setting-null

makasim · web-flow · commit 3403f7ec96d1 · 2017-08-04T18:15:38.000+03:00
[producer] do not throw exception if feature not implemented and null…
diff --git a/pkg/amqp-bunny/AmqpProducer.php b/pkg/amqp-bunny/AmqpProducer.php
@@ -92,6 +92,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();
     }
 
diff --git a/pkg/amqp-ext/AmqpProducer.php b/pkg/amqp-ext/AmqpProducer.php
@@ -99,6 +99,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();
     }
 
diff --git a/pkg/amqp-lib/AmqpProducer.php b/pkg/amqp-lib/AmqpProducer.php
@@ -94,6 +94,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();
     }
 
diff --git a/pkg/dbal/DbalProducer.php b/pkg/dbal/DbalProducer.php
@@ -91,6 +91,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -107,6 +111,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -123,6 +131,10 @@ public function getPriority()
      */
     public function setTimeToLive($timeToLive)
     {
+        if (null === $timeToLive) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
diff --git a/pkg/fs/FsProducer.php b/pkg/fs/FsProducer.php
@@ -73,6 +73,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();
     }
 
@@ -89,6 +93,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw PriorityNotSupportedException::providerDoestNotSupportIt();
     }
 
diff --git a/pkg/gearman/GearmanProducer.php b/pkg/gearman/GearmanProducer.php
@@ -47,6 +47,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -63,6 +67,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -79,6 +87,10 @@ public function getPriority()
      */
     public function setTimeToLive($timeToLive)
     {
+        if (null === $timeToLive) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
diff --git a/pkg/pheanstalk/PheanstalkProducer.php b/pkg/pheanstalk/PheanstalkProducer.php
@@ -57,6 +57,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -73,6 +77,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -89,6 +97,10 @@ public function getPriority()
      */
     public function setTimeToLive($timeToLive)
     {
+        if (null === $timeToLive) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
diff --git a/pkg/rdkafka/RdKafkaProducer.php b/pkg/rdkafka/RdKafkaProducer.php
@@ -48,6 +48,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -64,6 +68,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -80,6 +88,10 @@ public function getPriority()
      */
     public function setTimeToLive($timeToLive)
     {
+        if (null === $timeToLive) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
diff --git a/pkg/redis/RedisProducer.php b/pkg/redis/RedisProducer.php
@@ -42,6 +42,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -58,6 +62,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -74,6 +82,10 @@ public function getPriority()
      */
     public function setTimeToLive($timeToLive)
     {
+        if (null === $timeToLive) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
diff --git a/pkg/sqs/SqsProducer.php b/pkg/sqs/SqsProducer.php
@@ -108,6 +108,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw PriorityNotSupportedException::providerDoestNotSupportIt();
     }
 
@@ -124,6 +128,10 @@ public function getPriority()
      */
     public function setTimeToLive($timeToLive)
     {
+        if (null === $timeToLive) {
+            return;
+        }
+
         throw TimeToLiveNotSupportedException::providerDoestNotSupportIt();
     }
 
diff --git a/pkg/stomp/StompProducer.php b/pkg/stomp/StompProducer.php
@@ -50,6 +50,10 @@ public function send(PsrDestination $destination, PsrMessage $message)
      */
     public function setDeliveryDelay($deliveryDelay)
     {
+        if (null === $deliveryDelay) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -66,6 +70,10 @@ public function getDeliveryDelay()
      */
     public function setPriority($priority)
     {
+        if (null === $priority) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 
@@ -82,6 +90,10 @@ public function getPriority()
      */
     public function setTimeToLive($timeToLive)
     {
+        if (null === $timeToLive) {
+            return;
+        }
+
         throw new \LogicException('Not implemented');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`92`	`92`	`*/`
`93`	`93`	`public function setDeliveryDelay($deliveryDelay)`
`94`	`94`	`{`
	`95`	`+ if (null === $deliveryDelay) {`
	`96`	`+ return;`
	`97`	`+ }`
	`98`	`+`
`95`	`99`	`throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();`
`96`	`100`	`}`
`97`	`101`
Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`99`	`99`	`*/`
`100`	`100`	`public function setDeliveryDelay($deliveryDelay)`
`101`	`101`	`{`
	`102`	`+ if (null === $deliveryDelay) {`
	`103`	`+ return;`
	`104`	`+ }`
	`105`	`+`
`102`	`106`	`throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();`
`103`	`107`	`}`
`104`	`108`
Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`94`	`94`	`*/`
`95`	`95`	`public function setDeliveryDelay($deliveryDelay)`
`96`	`96`	`{`
	`97`	`+ if (null === $deliveryDelay) {`
	`98`	`+ return;`
	`99`	`+ }`
	`100`	`+`
`97`	`101`	`throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();`
`98`	`102`	`}`
`99`	`103`
Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`91`	`91`	`*/`
`92`	`92`	`public function setDeliveryDelay($deliveryDelay)`
`93`	`93`	`{`
	`94`	`+ if (null === $deliveryDelay) {`
	`95`	`+ return;`
	`96`	`+ }`
	`97`	`+`
`94`	`98`	`throw new \LogicException('Not implemented');`
`95`	`99`	`}`
`96`	`100`
`@@ -107,6 +111,10 @@ public function getDeliveryDelay()`
`107`	`111`	`*/`
`108`	`112`	`public function setPriority($priority)`
`109`	`113`	`{`
	`114`	`+ if (null === $priority) {`
	`115`	`+ return;`
	`116`	`+ }`
	`117`	`+`
`110`	`118`	`throw new \LogicException('Not implemented');`
`111`	`119`	`}`
`112`	`120`
`@@ -123,6 +131,10 @@ public function getPriority()`
`123`	`131`	`*/`
`124`	`132`	`public function setTimeToLive($timeToLive)`
`125`	`133`	`{`
	`134`	`+ if (null === $timeToLive) {`
	`135`	`+ return;`
	`136`	`+ }`
	`137`	`+`
`126`	`138`	`throw new \LogicException('Not implemented');`
`127`	`139`	`}`
`128`	`140`
Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`73`	`73`	`*/`
`74`	`74`	`public function setDeliveryDelay($deliveryDelay)`
`75`	`75`	`{`
	`76`	`+ if (null === $deliveryDelay) {`
	`77`	`+ return;`
	`78`	`+ }`
	`79`	`+`
`76`	`80`	`throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();`
`77`	`81`	`}`
`78`	`82`
`@@ -89,6 +93,10 @@ public function getDeliveryDelay()`
`89`	`93`	`*/`
`90`	`94`	`public function setPriority($priority)`
`91`	`95`	`{`
	`96`	`+ if (null === $priority) {`
	`97`	`+ return;`
	`98`	`+ }`
	`99`	`+`
`92`	`100`	`throw PriorityNotSupportedException::providerDoestNotSupportIt();`
`93`	`101`	`}`
`94`	`102`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`47`	`47`	`*/`
`48`	`48`	`public function setDeliveryDelay($deliveryDelay)`
`49`	`49`	`{`
	`50`	`+ if (null === $deliveryDelay) {`
	`51`	`+ return;`
	`52`	`+ }`
	`53`	`+`
`50`	`54`	`throw new \LogicException('Not implemented');`
`51`	`55`	`}`
`52`	`56`
`@@ -63,6 +67,10 @@ public function getDeliveryDelay()`
`63`	`67`	`*/`
`64`	`68`	`public function setPriority($priority)`
`65`	`69`	`{`
	`70`	`+ if (null === $priority) {`
	`71`	`+ return;`
	`72`	`+ }`
	`73`	`+`
`66`	`74`	`throw new \LogicException('Not implemented');`
`67`	`75`	`}`
`68`	`76`
`@@ -79,6 +87,10 @@ public function getPriority()`
`79`	`87`	`*/`
`80`	`88`	`public function setTimeToLive($timeToLive)`
`81`	`89`	`{`
	`90`	`+ if (null === $timeToLive) {`
	`91`	`+ return;`
	`92`	`+ }`
	`93`	`+`
`82`	`94`	`throw new \LogicException('Not implemented');`
`83`	`95`	`}`
`84`	`96`
Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`57`	`57`	`*/`
`58`	`58`	`public function setDeliveryDelay($deliveryDelay)`
`59`	`59`	`{`
	`60`	`+ if (null === $deliveryDelay) {`
	`61`	`+ return;`
	`62`	`+ }`
	`63`	`+`
`60`	`64`	`throw new \LogicException('Not implemented');`
`61`	`65`	`}`
`62`	`66`
`@@ -73,6 +77,10 @@ public function getDeliveryDelay()`
`73`	`77`	`*/`
`74`	`78`	`public function setPriority($priority)`
`75`	`79`	`{`
	`80`	`+ if (null === $priority) {`
	`81`	`+ return;`
	`82`	`+ }`
	`83`	`+`
`76`	`84`	`throw new \LogicException('Not implemented');`
`77`	`85`	`}`
`78`	`86`
`@@ -89,6 +97,10 @@ public function getPriority()`
`89`	`97`	`*/`
`90`	`98`	`public function setTimeToLive($timeToLive)`
`91`	`99`	`{`
	`100`	`+ if (null === $timeToLive) {`
	`101`	`+ return;`
	`102`	`+ }`
	`103`	`+`
`92`	`104`	`throw new \LogicException('Not implemented');`
`93`	`105`	`}`
`94`	`106`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`48`	`48`	`*/`
`49`	`49`	`public function setDeliveryDelay($deliveryDelay)`
`50`	`50`	`{`
	`51`	`+ if (null === $deliveryDelay) {`
	`52`	`+ return;`
	`53`	`+ }`
	`54`	`+`
`51`	`55`	`throw new \LogicException('Not implemented');`
`52`	`56`	`}`
`53`	`57`
`@@ -64,6 +68,10 @@ public function getDeliveryDelay()`
`64`	`68`	`*/`
`65`	`69`	`public function setPriority($priority)`
`66`	`70`	`{`
	`71`	`+ if (null === $priority) {`
	`72`	`+ return;`
	`73`	`+ }`
	`74`	`+`
`67`	`75`	`throw new \LogicException('Not implemented');`
`68`	`76`	`}`
`69`	`77`
`@@ -80,6 +88,10 @@ public function getPriority()`
`80`	`88`	`*/`
`81`	`89`	`public function setTimeToLive($timeToLive)`
`82`	`90`	`{`
	`91`	`+ if (null === $timeToLive) {`
	`92`	`+ return;`
	`93`	`+ }`
	`94`	`+`
`83`	`95`	`throw new \LogicException('Not implemented');`
`84`	`96`	`}`
`85`	`97`
Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,10 @@ public function send(PsrDestination $destination, PsrMessage $message)`
`42`	`42`	`*/`
`43`	`43`	`public function setDeliveryDelay($deliveryDelay)`
`44`	`44`	`{`
	`45`	`+ if (null === $deliveryDelay) {`
	`46`	`+ return;`
	`47`	`+ }`
	`48`	`+`
`45`	`49`	`throw new \LogicException('Not implemented');`
`46`	`50`	`}`
`47`	`51`
`@@ -58,6 +62,10 @@ public function getDeliveryDelay()`
`58`	`62`	`*/`
`59`	`63`	`public function setPriority($priority)`
`60`	`64`	`{`
	`65`	`+ if (null === $priority) {`
	`66`	`+ return;`
	`67`	`+ }`
	`68`	`+`
`61`	`69`	`throw new \LogicException('Not implemented');`
`62`	`70`	`}`
`63`	`71`
`@@ -74,6 +82,10 @@ public function getPriority()`
`74`	`82`	`*/`
`75`	`83`	`public function setTimeToLive($timeToLive)`
`76`	`84`	`{`
	`85`	`+ if (null === $timeToLive) {`
	`86`	`+ return;`
	`87`	`+ }`
	`88`	`+`
`77`	`89`	`throw new \LogicException('Not implemented');`
`78`	`90`	`}`
`79`	`91`
Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,10 @@ public function getDeliveryDelay()`
`108`	`108`	`*/`
`109`	`109`	`public function setPriority($priority)`
`110`	`110`	`{`
	`111`	`+ if (null === $priority) {`
	`112`	`+ return;`
	`113`	`+ }`
	`114`	`+`
`111`	`115`	`throw PriorityNotSupportedException::providerDoestNotSupportIt();`
`112`	`116`	`}`
`113`	`117`
`@@ -124,6 +128,10 @@ public function getPriority()`
`124`	`128`	`*/`
`125`	`129`	`public function setTimeToLive($timeToLive)`
`126`	`130`	`{`
	`131`	`+ if (null === $timeToLive) {`
	`132`	`+ return;`
	`133`	`+ }`
	`134`	`+`
`127`	`135`	`throw TimeToLiveNotSupportedException::providerDoestNotSupportIt();`
`128`	`136`	`}`
`129`	`137`