Merge branch 'master' of github.com:php-enqueue/enqueue-dev

Author: makasim

pkg/amqp-ext/AmqpConnectionFactory.php

@@ -55,7 +55,7 @@ public function __construct(array $config)
     public function createContext()
     {
         if ($this->config['lazy']) {
-            return new AmqpContext(function() {
+            return new AmqpContext(function () {
                 return new \AMQPChannel($this->establishConnection());
             });
         }

pkg/amqp-ext/Tests/AmqpConnectionFactoryTest.php

@@ -61,6 +61,6 @@ public function testShouldCreateLazyContext()
         $this->assertInstanceOf(AmqpContext::class, $context);
 
         $this->assertAttributeEquals(null, 'extChannel', $context);
-        $this->assertTrue(is_callable($this->readAttribute($context, 'extChannelFactory')));
+        $this->assertInternalType('callable', $this->readAttribute($context, 'extChannelFactory'));
     }
 }

pkg/enqueue/Client/MessageProducer.php

@@ -58,7 +58,7 @@ private function prepareBody(Message $message)
         $body = $message->getBody();
         $contentType = $message->getContentType();
 
-        if (is_scalar($body) || is_null($body)) {
+        if (is_scalar($body) || null === $body) {
             $contentType = $contentType ?: 'text/plain';
             $body = (string) $body;
         } elseif (is_array($body)) {
@@ -68,7 +68,7 @@ private function prepareBody(Message $message)
 
             // only array of scalars is allowed.
             array_walk_recursive($body, function ($value) {
-                if (!is_scalar($value) && !is_null($value)) {
+                if (!is_scalar($value) && null !== $value) {
                     throw new \LogicException(sprintf(
                         'The message\'s body must be an array of scalars. Found not scalar in the array: %s',
                         is_object($value) ? get_class($value) : gettype($value)

pkg/enqueue/Client/SimpleClient.php

@@ -71,8 +71,8 @@ public function __construct(AmqpContext $context, Config $config = null)
     }
 
     /**
-     * @param string $topic
-     * @param string $processorName
+     * @param string   $topic
+     * @param string   $processorName
      * @param callback $processor
      */
     public function bind($topic, $processorName, callable $processor)

pkg/enqueue/Tests/Client/MessageProducerTest.php

@@ -414,4 +414,4 @@ public function jsonSerialize()
     {
         return ['foo' => 'fooVal'];
     }
-};
+}

pkg/enqueue/Tests/Consumption/QueueConsumerTest.php

@@ -955,8 +955,9 @@ public function testShouldCallEachQueueOneByOne()
     }
 
     /**
+     * @param null|mixed $message
+     *
      * @return \PHPUnit_Framework_MockObject_MockObject|Consumer
-     * @param  null|mixed                                        $message
      */
     protected function createMessageConsumerStub($message = null)
     {
@@ -971,8 +972,9 @@ protected function createMessageConsumerStub($message = null)
     }
 
     /**
+     * @param null|mixed $messageConsumer
+     *
      * @return \PHPUnit_Framework_MockObject_MockObject|PsrContext
-     * @param  null|mixed                                          $messageConsumer
      */
     protected function createPsrContextStub($messageConsumer = null)
     {

pkg/enqueue/Tests/Symfony/Client/Meta/QueuesCommandTest.php

@@ -90,8 +90,9 @@ protected function executeCommand(Command $command, array $arguments = [])
     }
 
     /**
+     * @param mixed $destinations
+     *
      * @return \PHPUnit_Framework_MockObject_MockObject|QueueMetaRegistry
-     * @param  mixed                                                      $destinations
      */
     protected function createQueueMetaRegistryStub($destinations = [])
     {

pkg/enqueue/Tests/Util/JSONTest.php

@@ -37,6 +37,7 @@ public function nonStringDataProvider()
 
     /**
      * @dataProvider nonStringDataProvider
+     *
      * @param mixed $value
      */
     public function testShouldThrowExceptionIfInputIsNotString($value)

pkg/enqueue/Tests/Util/VarExportTest.php

@@ -13,6 +13,7 @@ public function testCouldBeConstructedWithValueAsArgument()
 
     /**
      * @dataProvider provideValues
+     *
      * @param mixed $value
      * @param mixed $expected
      */

pkg/fs/Client/FsDriver.php

@@ -173,7 +173,7 @@ public function getConfig()
     private function createRouterTopic()
     {
         return $this->context->createTopic(
-            $this->config->createTransportRouterTopicName($this->config->getRouterTopicName())
+            $this->config->createTransportQueueName($this->config->getRouterTopicName())
         );
     }
 }