Skip to content

SetRouterPropertiesExtension does not work with SQS #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iainmckay opened this issue Nov 10, 2017 · 4 comments
Closed

SetRouterPropertiesExtension does not work with SQS #261

iainmckay opened this issue Nov 10, 2017 · 4 comments
Labels

Comments

@iainmckay
Copy link
Contributor

The SqsDriver creates queue names where dots (.) are replaced with a literal 'dot' string. SetRouterPropertiesExtension is checking that the queue it is being called is the router but Config::createTransportQueueName creates an invalid queue name for SQS as it is not aware of the string replacement.

@makasim
Copy link
Member

makasim commented Nov 10, 2017

I believe the extension should use the driver's method createQueue instead of checking against config's value.

@makasim makasim added the bug label Nov 10, 2017
@iainmckay
Copy link
Contributor Author

iainmckay commented Nov 10, 2017

That would make sense and easy to implement, although it does seem a bit wasteful to create a PsrQueue instance on each invocation.

Possibly the name building should be extracted in to a createQueueName method which createQueue uses. It looks like each driver would need updated for this though.

If you're happy, I can create a PR which updates the extension using createQueue.

@makasim
Copy link
Member

makasim commented Nov 10, 2017

createQueue method and PsrQueue object are supposed to be as lightweight as possible. I don't see much problem with creating it.

@makasim
Copy link
Member

makasim commented Nov 10, 2017

If you're happy, I can create a PR which updates the extension using createQueue.

That would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants