-
Notifications
You must be signed in to change notification settings - Fork 440
SetRouterPropertiesExtension does not work with SQS #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe the extension should use the driver's method createQueue instead of checking against config's value. |
That would make sense and easy to implement, although it does seem a bit wasteful to create a Possibly the name building should be extracted in to a If you're happy, I can create a PR which updates the extension using |
createQueue method and PsrQueue object are supposed to be as lightweight as possible. I don't see much problem with creating it. |
That would be great. |
The SqsDriver creates queue names where dots (.) are replaced with a literal 'dot' string. SetRouterPropertiesExtension is checking that the queue it is being called is the router but Config::createTransportQueueName creates an invalid queue name for SQS as it is not aware of the string replacement.
The text was updated successfully, but these errors were encountered: